Fix Vega react eslint errors (#54259) (#54284)

elastic · Jan 9, 2020 · 7ed0906 · 7ed0906
1 parent 16d375f
commit 7ed0906
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -113,12 +113,6 @@ module.exports = {
         'react-hooks/exhaustive-deps': 'off',
       },
     },
-    {
-      files: ['src/legacy/core_plugins/vis_type_vega/**/*.{js,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
     {
       files: ['src/legacy/ui/public/vis/**/*.{js,ts,tsx}'],
       rules: {

diff --git a/src/legacy/core_plugins/vis_type_vega/public/components/vega_actions_menu.tsx b/src/legacy/core_plugins/vis_type_vega/public/components/vega_actions_menu.tsx
@@ -34,12 +34,12 @@ function VegaActionsMenu({ formatHJson, formatJson }: VegaActionsMenuProps) {
   const onHJsonCLick = useCallback(() => {
     formatHJson();
     setIsPopoverOpen(false);
-  }, [isPopoverOpen, formatHJson]);
+  }, [formatHJson]);
 
   const onJsonCLick = useCallback(() => {
     formatJson();
     setIsPopoverOpen(false);
-  }, [isPopoverOpen, formatJson]);
+  }, [formatJson]);
 
   const closePopover = useCallback(() => setIsPopoverOpen(false), []);