Merge branch 'master' into tsvb-click-filter

.github/CODEOWNERS

@@ -188,6 +188,7 @@
 /src/core/  @elastic/kibana-core
 /src/plugins/saved_objects_tagging_oss  @elastic/kibana-core
 /config/kibana.yml @elastic/kibana-core
+/x-pack/plugins/banners/  @elastic/kibana-core
 /x-pack/plugins/features/  @elastic/kibana-core
 /x-pack/plugins/licensing/  @elastic/kibana-core
 /x-pack/plugins/global_search/  @elastic/kibana-core

Jenkinsfile

@@ -6,7 +6,7 @@ kibanaLibrary.load()
 kibanaPipeline(timeoutMinutes: 210, checkPrChanges: true, setCommitStatus: true) {
   slackNotifications.onFailure(disabled: !params.NOTIFY_ON_FAILURE) {
     githubPr.withDefaultPrComments {
-      ciStats.trackBuild(requireSuccess: githubPr.isPr()) {
+      ciStats.trackBuild(requireSuccess: githubPr.isTrackedBranchPr()) {
         catchError {
           retryable.enable()
           kibanaPipeline.allCiTasks()

STYLEGUIDE.mdx

@@ -1,7 +1,7 @@
 ---
 id: kibStyleGuide
 slug: /kibana-dev-docs/styleguide
-title: StyleGuide
+title: Style Guide
 summary: JavaScript/TypeScript styleguide.
 date: 2021-05-06
 tags: ['kibana', 'onboarding', 'dev', 'styleguide', 'typescript', 'javascript']
@@ -680,7 +680,7 @@ Using `react-component` means adding a bunch of components into angular, while `
 
 ### Action function names and prop function names
 
-Name action functions in the form of a strong verb and passed properties in the form of on<Subject><Change>. E.g:
+Name action functions in the form of a strong verb and passed properties in the form of `on<Subject><Change>`. E.g:
 
 ```jsx
 <sort-button onClick={action.sort}/>

api_docs/spaces_oss.json

@@ -577,15 +577,11 @@
         "deprecated": false,
         "children": [
           {
-            "parentPluginId": "spacesOss",
-            "id": "def-public.SpacesApi.activeSpace$",
-            "type": "Object",
-            "tags": [],
-            "label": "activeSpace$",
-            "description": [
-              "\nObservable representing the currently active space.\nThe details of the space can change without a full page reload (such as display name, color, etc.)"
-            ],
+            "id": "def-public.SpacesApi.getActiveSpace$",
+            "type": "Function",
+            "label": "getActiveSpace$",
             "signature": [
+              "() => ",
               "Observable",
               "<",
               {
@@ -597,11 +593,16 @@
               },
               ">"
             ],
+            "description": [
+              "\nObservable representing the currently active space.\nThe details of the space can change without a full page reload (such as display name, color, etc.)"
+            ],
+            "children": [],
+            "tags": [],
+            "returnComment": [],
             "source": {
               "path": "src/plugins/spaces_oss/public/api.ts",
               "lineNumber": 22
-            },
-            "deprecated": false
+            }
           },
           {
             "parentPluginId": "spacesOss",

docs/developer/contributing/development-functional-tests.asciidoc

@@ -140,7 +140,7 @@ export default function (/* { providerAPI } */) {
 -----------
 
 **Services**:::
-Services are named singleton values produced by a Service Provider. Tests and other services can retrieve service instances by asking for them by name. All functionality except the mocha API is exposed via services.\
+Services are named singleton values produced by a Service Provider. Tests and other services can retrieve service instances by asking for them by name. All functionality except the mocha API is exposed via services.
 
 **Page objects**:::
 Page objects are a special type of service that encapsulate behaviors common to a particular page or plugin. When you write your own plugin, you’ll likely want to add a page object (or several) that describes the common interactions your tests need to execute.

docs/development/core/public/kibana-plugin-core-public.doclinksstart.links.md

@@ -144,6 +144,7 @@ readonly links: {
             createSnapshotLifecyclePolicy: string;
             createRoleMapping: string;
             createRoleMappingTemplates: string;
+            createRollupJobsRequest: string;
             createApiKey: string;
             createPipeline: string;
             createTransformRequest: string;

docs/development/core/server/kibana-plugin-core-server.assistanceapiresponse.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 <b>Signature:</b>

docs/development/core/server/kibana-plugin-core-server.assistantapiclientparams.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 <b>Signature:</b>

docs/development/core/server/kibana-plugin-core-server.deprecationapiclientparams.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 <b>Signature:</b>

docs/development/core/server/kibana-plugin-core-server.deprecationapiresponse.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 <b>Signature:</b>

docs/development/core/server/kibana-plugin-core-server.deprecationinfo.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 <b>Signature:</b>

docs/development/core/server/kibana-plugin-core-server.ilegacyclusterclient.md

@@ -6,7 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
-> Use [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.
+> Use [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.  7.16
 > 
 
 Represents an Elasticsearch cluster API client created by the platform. It allows to call API on behalf of the internal Kibana user and the actual user that is derived from the request headers (via `asScoped(...)`<!-- -->).

docs/development/core/server/kibana-plugin-core-server.ilegacycustomclusterclient.md

@@ -6,7 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
-> Use [ICustomClusterClient](./kibana-plugin-core-server.icustomclusterclient.md)<!-- -->.
+> Use [ICustomClusterClient](./kibana-plugin-core-server.icustomclusterclient.md)<!-- -->.  7.16
 > 
 
 Represents an Elasticsearch cluster API client created by a plugin. It allows to call API on behalf of the internal Kibana user and the actual user that is derived from the request headers (via `asScoped(...)`<!-- -->).

docs/development/core/server/kibana-plugin-core-server.ilegacyscopedclusterclient.md

@@ -6,7 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
-> Use [IScopedClusterClient](./kibana-plugin-core-server.iscopedclusterclient.md)<!-- -->.
+> Use [IScopedClusterClient](./kibana-plugin-core-server.iscopedclusterclient.md)<!-- -->.  7.16
 > 
 
 Serves the same purpose as "normal" `ClusterClient` but exposes additional `callAsCurrentUser` method that doesn't use credentials of the Kibana internal user (as `callAsInternalUser` does) to request Elasticsearch API, but rather passes HTTP headers extracted from the current user request to the API.

docs/development/core/server/kibana-plugin-core-server.indexsettingsdeprecationinfo.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 <b>Signature:</b>

docs/development/core/server/kibana-plugin-core-server.legacyapicaller.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 <b>Signature:</b>

docs/development/core/server/kibana-plugin-core-server.legacycallapioptions.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 The set of options that defines how API call should be made and result be processed.

docs/development/core/server/kibana-plugin-core-server.legacyclusterclient.md

@@ -6,7 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
-> Use [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.
+> Use [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.  7.16
 > 
 
 Represents an Elasticsearch cluster API client created by the platform. It allows to call API on behalf of the internal Kibana user and the actual user that is derived from the request headers (via `asScoped(...)`<!-- -->).

docs/development/core/server/kibana-plugin-core-server.legacyelasticsearcherror.md

@@ -4,7 +4,7 @@
 
 ## LegacyElasticsearchError interface
 
-@<!-- -->deprecated. The new elasticsearch client doesn't wrap errors anymore.
+@<!-- -->deprecated. The new elasticsearch client doesn't wrap errors anymore.  7.16
 
 <b>Signature:</b>
 

docs/development/core/server/kibana-plugin-core-server.legacyscopedclusterclient.callascurrentuser.md

@@ -6,7 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
-> Use [IScopedClusterClient.asCurrentUser](./kibana-plugin-core-server.iscopedclusterclient.ascurrentuser.md)<!-- -->.
+> Use [IScopedClusterClient.asCurrentUser](./kibana-plugin-core-server.iscopedclusterclient.ascurrentuser.md)<!-- -->.  7.16
 > 
 
 Calls specified `endpoint` with provided `clientParams` on behalf of the user initiated request to the Kibana server (via HTTP request headers). See [LegacyAPICaller](./kibana-plugin-core-server.legacyapicaller.md)<!-- -->.

docs/development/core/server/kibana-plugin-core-server.legacyscopedclusterclient.callasinternaluser.md

@@ -6,7 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
-> Use [IScopedClusterClient.asInternalUser](./kibana-plugin-core-server.iscopedclusterclient.asinternaluser.md)<!-- -->.
+> Use [IScopedClusterClient.asInternalUser](./kibana-plugin-core-server.iscopedclusterclient.asinternaluser.md)<!-- -->.  7.16
 > 
 
 Calls specified `endpoint` with provided `clientParams` on behalf of the Kibana internal user. See [LegacyAPICaller](./kibana-plugin-core-server.legacyapicaller.md)<!-- -->.

docs/development/core/server/kibana-plugin-core-server.legacyscopedclusterclient.md

@@ -6,7 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
-> Use [scoped cluster client](./kibana-plugin-core-server.iscopedclusterclient.md)<!-- -->.
+> Use [scoped cluster client](./kibana-plugin-core-server.iscopedclusterclient.md)<!-- -->.  7.16
 > 
 
 Serves the same purpose as the normal [cluster client](./kibana-plugin-core-server.iclusterclient.md) but exposes an additional `asCurrentUser` method that doesn't use credentials of the Kibana internal user (as `asInternalUser` does) to request Elasticsearch API, but rather passes HTTP headers extracted from the current user request to the API instead.

docs/development/core/server/kibana-plugin-core-server.md

@@ -108,7 +108,7 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
 |  [KibanaRequestRoute](./kibana-plugin-core-server.kibanarequestroute.md) | Request specific route information exposed to a handler. |
 |  [LegacyAPICaller](./kibana-plugin-core-server.legacyapicaller.md) |  |
 |  [LegacyCallAPIOptions](./kibana-plugin-core-server.legacycallapioptions.md) | The set of options that defines how API call should be made and result be processed. |
-|  [LegacyElasticsearchError](./kibana-plugin-core-server.legacyelasticsearcherror.md) | @<!-- -->deprecated. The new elasticsearch client doesn't wrap errors anymore. |
+|  [LegacyElasticsearchError](./kibana-plugin-core-server.legacyelasticsearcherror.md) | @<!-- -->deprecated. The new elasticsearch client doesn't wrap errors anymore.  7.16 |
 |  [LegacyRequest](./kibana-plugin-core-server.legacyrequest.md) |  |
 |  [LoggerContextConfigInput](./kibana-plugin-core-server.loggercontextconfiginput.md) |  |
 |  [LoggingServiceSetup](./kibana-plugin-core-server.loggingservicesetup.md) | Provides APIs to plugins for customizing the plugin's logger. |

docs/development/core/server/kibana-plugin-core-server.migration_assistance_index_action.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 <b>Signature:</b>

docs/development/core/server/kibana-plugin-core-server.migration_deprecation_level.md

@@ -6,6 +6,7 @@
 
 > Warning: This API is now obsolete.
 > 
+>  7.16
 > 
 
 <b>Signature:</b>

docs/user/dashboard/tsvb.asciidoc

@@ -2,7 +2,8 @@
 === TSVB
 
 *TSVB* enables you to visualize the data from multiple data series, supports <<aggregation-reference, 
-most {es} metric aggregations>>, multiple visualization types, custom functions, and some math. To use *TSVB*, your data must have a date field. 
+most {es} metric aggregations>>, multiple visualization types, custom functions, and some math. 
+To create *TSVB* visualization panels, your data must have a time field. 
 
 [role="screenshot"]
 image::visualize/images/tsvb-screenshot.png[TSVB overview]
@@ -17,15 +18,19 @@ Open *TSVB*, then make sure the required settings are configured.
 
 . On the *New visualization* window, click *TSVB*.
 
-. In *TSVB*, click *Panel options*, then make sure the following settings are configured:
+. In *TSVB*, click *Panel options*, then specify the required *Data* settings.
 
-* *Index pattern*
-* *Time field*
-* *Interval*
+.. From the *Index pattern* dropdown, select the index pattern you want to visualize. 
++
+To visualize an {es} index, open the *Index pattern select mode* menu, deselect *Use only {kib} index patterns*, then enter the {es} index.
+
+.. From the *Time field* dropdown, select the field you want to visualize, then enter the field *Interval*.
 
-. Select a *Drop last bucket* option. It is dropped by default because the time filter intersects the time range of the last bucket, but can be enabled to see the partial data.
+.. Select a *Drop last bucket* option. 
++
+By default, *TSVB* drops the last bucket because the time filter intersects the time range of the last bucket. To view the partial data, select *No*.
 
-. In the *Panel filter* field, specify any <<kuery-query, KQL filters>> to select specific documents.
+.. In the *Panel filter* field, enter <<kuery-query, KQL filters>> to view specific documents.
 
 [float]
 [[configure-the-data-series]]

docs/user/security/authentication/index.asciidoc

@@ -7,6 +7,7 @@
 
 {kib} supports the following authentication mechanisms:
 
+- <<multiple-authentication-providers>>
 - <<basic-authentication>>
 - <<token-authentication>>
 - <<pki-authentication>>
@@ -16,15 +17,20 @@
 - <<anonymous-authentication>>
 - <<http-authentication>>
 
-Enable multiple authentication mechanisms at the same time specifying a prioritized list of the authentication _providers_ (typically of various types) in the configuration. Providers are consulted in ascending order. Make sure each configured provider has a unique name (e.g. `basic1` or `saml1` in the configuration example) and `order` setting. In the event that two or more providers have the same name or `order`, {kib} will fail to start.
+For an introduction to {kib}'s security features, including the login process, refer to <<tutorial-secure-access-to-kibana>>.
+
+[[multiple-authentication-providers]]
+==== Multiple authentication providers
+
+Enable multiple authentication mechanisms at the same time by specifying a prioritized list of the authentication _providers_ (typically of various types) in the configuration. Providers are consulted in ascending order. Make sure each configured provider has a unique name (e.g. `basic1` or `saml1` in the configuration example) and `order` setting. In the event that two or more providers have the same name or `order`, {kib} will fail to start.
 
 When two or more providers are configured, you can choose the provider you want to use on the Login Selector UI. The order the providers appear is determined by the `order` setting. The appearance of the specific provider entry can be customized with the `description`, `hint`, and `icon` settings.
 
 TIP: To provide login instructions to users, use the `xpack.security.loginHelp` setting, which supports Markdown format. When you specify the `xpack.security.loginHelp` setting, the Login Selector UI displays a `Need help?` link that lets users access login help information.
 
 If you don't want a specific provider to show up at the Login Selector UI (e.g. to only support third-party initiated login) you can hide it with `showInSelector` setting set to `false`. However, in this case, the provider is presented in the provider chain and may be consulted during authentication based on its `order`. To disable the provider, use the `enabled` setting.
 
-TIP: The Login Selector UI can also be disabled or enabled with `xpack.security.authc.selector.enabled` setting. 
+TIP: The Login Selector UI can also be disabled or enabled with `xpack.security.authc.selector.enabled` setting.
 
 Here is how your `kibana.yml` and Login Selector UI can look like if you deal with multiple authentication providers:
 
@@ -292,9 +298,9 @@ xpack.security.authc.providers:
     order: 1
 -----------------------------------------------
 
-IMPORTANT: {kib} uses SPNEGO, which wraps the Kerberos protocol for use with HTTP, extending it to web applications. 
+IMPORTANT: {kib} uses SPNEGO, which wraps the Kerberos protocol for use with HTTP, extending it to web applications.
 At the end of the Kerberos handshake, {kib} forwards the service ticket to {es}, then {es} unpacks the service ticket and responds with an access and refresh token, which are used for subsequent authentication.
-On every {es} node that {kib} connects to, the keytab file should always contain the HTTP service principal for the {kib} host. 
+On every {es} node that {kib} connects to, the keytab file should always contain the HTTP service principal for the {kib} host.
 The HTTP service principal name must have the `HTTP/kibana.domain.local@KIBANA.DOMAIN.LOCAL` format.
 
 
@@ -386,7 +392,7 @@ xpack.security.authc.providers:
 [[anonymous-access-and-embedding]]
 ===== Anonymous access and embedding
 
-One of the most popular use cases for anonymous access is when you embed {kib} into other applications and don't want to force your users to log in to view it. 
+One of the most popular use cases for anonymous access is when you embed {kib} into other applications and don't want to force your users to log in to view it.
 If you configured {kib} to use anonymous access as the sole authentication mechanism, you don't need to do anything special while embedding {kib}.
 
 If you have multiple authentication providers enabled, and you want to automatically log in anonymous users when embedding dashboards and visualizations:

examples/search_examples/common/index.ts

@@ -6,17 +6,7 @@
  * Side Public License, v 1.
  */
 
-import { IEsSearchResponse, IEsSearchRequest } from '../../../src/plugins/data/common';
-
 export const PLUGIN_ID = 'searchExamples';
 export const PLUGIN_NAME = 'Search Examples';
 
-export interface IMyStrategyRequest extends IEsSearchRequest {
-  get_cool: boolean;
-}
-export interface IMyStrategyResponse extends IEsSearchResponse {
-  cool: string;
-  executed_at: number;
-}
-
 export const SERVER_SEARCH_ROUTE_PATH = '/api/examples/search';

examples/search_examples/common/types.ts

@@ -0,0 +1,26 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import {
+  IEsSearchRequest,
+  IEsSearchResponse,
+  IKibanaSearchRequest,
+  IKibanaSearchResponse,
+} from '../../../src/plugins/data/common';
+
+export interface IMyStrategyRequest extends IEsSearchRequest {
+  get_cool: boolean;
+}
+export interface IMyStrategyResponse extends IEsSearchResponse {
+  cool: string;
+  executed_at: number;
+}
+
+export type FibonacciRequest = IKibanaSearchRequest<{ n: number }>;
+
+export type FibonacciResponse = IKibanaSearchResponse<{ values: number[] }>;