From bda7f8e9ae0450db34a184a9a1c0f56f019e1698 Mon Sep 17 00:00:00 2001 From: Ece Ozalp Date: Tue, 17 Aug 2021 15:13:53 -0400 Subject: [PATCH] remove todo comments --- .../integration/detection_alerts/cti_enrichments.spec.ts | 1 - .../integration/detection_rules/indicator_match_rule.spec.ts | 4 ---- 2 files changed, 5 deletions(-) diff --git a/x-pack/plugins/security_solution/cypress/integration/detection_alerts/cti_enrichments.spec.ts b/x-pack/plugins/security_solution/cypress/integration/detection_alerts/cti_enrichments.spec.ts index 4ada4321782d9..8ce3de6e5d7ac 100644 --- a/x-pack/plugins/security_solution/cypress/integration/detection_alerts/cti_enrichments.spec.ts +++ b/x-pack/plugins/security_solution/cypress/integration/detection_alerts/cti_enrichments.spec.ts @@ -37,7 +37,6 @@ import { import { ALERTS_URL } from '../../urls/navigation'; import { addsFieldsToTimeline } from '../../tasks/rule_details'; -// TODO: Doesn't look like the roll over is happening for these tests. 'indicator' is still referenced in the fields browser describe('CTI Enrichment', () => { before(() => { cleanKibana(); diff --git a/x-pack/plugins/security_solution/cypress/integration/detection_rules/indicator_match_rule.spec.ts b/x-pack/plugins/security_solution/cypress/integration/detection_rules/indicator_match_rule.spec.ts index 8721b59d85556..f8b3b426580b2 100644 --- a/x-pack/plugins/security_solution/cypress/integration/detection_rules/indicator_match_rule.spec.ts +++ b/x-pack/plugins/security_solution/cypress/integration/detection_rules/indicator_match_rule.spec.ts @@ -139,7 +139,6 @@ describe('indicator match', () => { getIndicatorIndex().should('have.text', getIndexPatterns().join('')); }); - // TODO: Need to fix it('Does NOT show invalidation text on initial page load if indicator index pattern is filled out', () => { getDefineContinueButton().click(); getIndexPatternInvalidationText().should('not.exist'); @@ -154,7 +153,6 @@ describe('indicator match', () => { }); describe('Indicator index patterns', () => { - // TODO: Need to fix it('Contains a predefined index pattern', () => { getIndicatorIndicatorIndex().should('have.text', getThreatIndexPatterns().join('')); }); @@ -392,7 +390,6 @@ describe('indicator match', () => { loginAndWaitForPageWithoutDateRange(ALERTS_URL); }); - // TODO: Need to fix it('Creates and activates a new Indicator Match rule', () => { waitForAlertsPanelToBeLoaded(); waitForAlertsIndexToBeCreated(); @@ -491,7 +488,6 @@ describe('indicator match', () => { .should('have.text', getNewThreatIndicatorRule().riskScore); }); - // TODO: Need to fix it('Investigate alert in timeline', () => { const accessibilityText = `Press enter for options, or press space to begin dragging.`;