Skip to content

Commit

Permalink
[8.10] [Discover] Unskip "search source fetch" flaky tests (#165586) (#…
Browse files Browse the repository at this point in the history
…165932)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Discover] Unskip "search source fetch" flaky tests
(#165586)](#165586)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-09-07T05:57:32Z","message":"[Discover]
Unskip \"search source fetch\" flaky tests (#165586)\n\nNormal
test:\r\n- Closes
https://github.com/elastic/kibana/issues/139879\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3056\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3070\r\n\r\nSimilar
Serverless tests:\r\n-
https://github.com/elastic/kibana/issues/165660\r\n-
https://github.com/elastic/kibana/issues/165624\r\n-
https://github.com/elastic/kibana/issues/165623\r\n-
https://github.com/elastic/kibana/issues/165503\r\n-
https://github.com/elastic/kibana/issues/165502\r\n-
https://github.com/elastic/kibana/issues/165379\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6d79b6751dbb345c477e542dfd222e5ac222d6b5","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.11.0"],"number":165586,"url":"https://github.com/elastic/kibana/pull/165586","mergeCommit":{"message":"[Discover]
Unskip \"search source fetch\" flaky tests (#165586)\n\nNormal
test:\r\n- Closes
https://github.com/elastic/kibana/issues/139879\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3056\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3070\r\n\r\nSimilar
Serverless tests:\r\n-
https://github.com/elastic/kibana/issues/165660\r\n-
https://github.com/elastic/kibana/issues/165624\r\n-
https://github.com/elastic/kibana/issues/165623\r\n-
https://github.com/elastic/kibana/issues/165503\r\n-
https://github.com/elastic/kibana/issues/165502\r\n-
https://github.com/elastic/kibana/issues/165379\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6d79b6751dbb345c477e542dfd222e5ac222d6b5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165586","number":165586,"mergeCommit":{"message":"[Discover]
Unskip \"search source fetch\" flaky tests (#165586)\n\nNormal
test:\r\n- Closes
https://github.com/elastic/kibana/issues/139879\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3056\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3070\r\n\r\nSimilar
Serverless tests:\r\n-
https://github.com/elastic/kibana/issues/165660\r\n-
https://github.com/elastic/kibana/issues/165624\r\n-
https://github.com/elastic/kibana/issues/165623\r\n-
https://github.com/elastic/kibana/issues/165503\r\n-
https://github.com/elastic/kibana/issues/165502\r\n-
https://github.com/elastic/kibana/issues/165379\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"6d79b6751dbb345c477e542dfd222e5ac222d6b5"}}]}]
BACKPORT-->
  • Loading branch information
jughosta authored Sep 7, 2023
1 parent 7e04474 commit dab2834
Showing 1 changed file with 13 additions and 6 deletions.
19 changes: 13 additions & 6 deletions test/examples/search/warnings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const kibanaServer = getService('kibanaServer');
const esArchiver = getService('esArchiver');

// Failing: See https://github.com/elastic/kibana/issues/139879
describe.skip('handling warnings with search source fetch', function () {
describe('handling warnings with search source fetch', function () {
const dataViewTitle = 'sample-01,sample-01-rollup';
const fromTime = 'Jun 17, 2022 @ 00:00:00.000';
const toTime = 'Jun 23, 2022 @ 00:00:00.000';
Expand Down Expand Up @@ -122,8 +121,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
// click "see full error" button in the toast
const [openShardModalButton] = await testSubjects.findAll('openShardFailureModalBtn');
await openShardModalButton.click();
const modalHeader = await testSubjects.find('shardFailureModalTitle');
expect(await modalHeader.getVisibleText()).to.be('2 of 4 shards failed');

await retry.waitFor('modal title visible', async () => {
const modalHeader = await testSubjects.find('shardFailureModalTitle');
return (await modalHeader.getVisibleText()) === '2 of 4 shards failed';
});

// request
await testSubjects.click('shardFailuresModalRequestButton');
const requestBlock = await testSubjects.find('shardsFailedModalRequestBlock');
Expand Down Expand Up @@ -169,8 +172,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const [openShardModalButton] = await testSubjects.findAll('openShardFailureModalBtn');
await openShardModalButton.click();
await testSubjects.exists('shardFailureModalTitle');
const modalHeader = await testSubjects.find('shardFailureModalTitle');
expect(await modalHeader.getVisibleText()).to.be('2 of 4 shards failed');

await retry.waitFor('modal title visible', async () => {
const modalHeader = await testSubjects.find('shardFailureModalTitle');
return (await modalHeader.getVisibleText()) === '2 of 4 shards failed';
});

// request
await testSubjects.click('shardFailuresModalRequestButton');
const requestBlock = await testSubjects.find('shardsFailedModalRequestBlock');
Expand Down

0 comments on commit dab2834

Please sign in to comment.