From e8982977aaf1cd314482ee0cec279dde6ec4cdbf Mon Sep 17 00:00:00 2001 From: Maja Grubic Date: Thu, 22 Sep 2022 13:28:19 +0200 Subject: [PATCH] Move selectors to constants --- .../page/kibana_template/impl/src/page_template_inner.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/shared-ux/page/kibana_template/impl/src/page_template_inner.tsx b/packages/shared-ux/page/kibana_template/impl/src/page_template_inner.tsx index 3dd6b7836179b..607b8fbd1776b 100644 --- a/packages/shared-ux/page/kibana_template/impl/src/page_template_inner.tsx +++ b/packages/shared-ux/page/kibana_template/impl/src/page_template_inner.tsx @@ -21,6 +21,9 @@ const getClasses = (template?: string, className?: string) => { ); }; +const KIBANA_CHROME_SELECTOR = '[data-test-subj="kibanaChrome"]'; +const HEADER_GLOBAL_NAV_SELECTOR = '[data-test-subj="headerGlobalNav"]'; + /** * A thin wrapper around EuiPageTemplate with a few Kibana specific additions */ @@ -38,10 +41,10 @@ export const KibanaPageTemplateInner: FC = ({ const [offset, setOffset] = useState(); useEffect(() => { - const kibanaChrome = document.querySelector('[data-test-subj="kibanaChrome"]') as HTMLElement; + const kibanaChrome = document.querySelector(KIBANA_CHROME_SELECTOR) as HTMLElement; if (kibanaChrome) { const kibanaChromeHeader = kibanaChrome.querySelector( - '[data-test-subj="headerGlobalNav"]' + HEADER_GLOBAL_NAV_SELECTOR ) as HTMLElement; setOffset(kibanaChromeHeader?.offsetTop + kibanaChromeHeader?.offsetHeight); }