fix: 🐛 don't overwrite explicitInput with combined input (#59938)

elastic · Mar 11, 2020 · f176550 · f176550
1 parent 5009f71
commit f176550
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.test.ts b/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.test.ts
@@ -58,6 +58,23 @@ describe('EmbeddableActionStorage', () => {
       expect(events2).toEqual([event]);
     });
 
+    test('does not merge .getInput() into .updateInput()', async () => {
+      const embeddable = new TestEmbeddable();
+      const storage = new EmbeddableActionStorage(embeddable);
+      const event: UiActionsSerializedEvent = {
+        eventId: 'EVENT_ID',
+        triggerId: 'TRIGGER-ID',
+        action: {} as any,
+      };
+
+      const spy = jest.spyOn(embeddable, 'updateInput');
+
+      await storage.create(event);
+
+      expect(spy.mock.calls[0][0].id).toBe(undefined);
+      expect(spy.mock.calls[0][0].viewMode).toBe(undefined);
+    });
+
     test('can create multiple events', async () => {
       const embeddable = new TestEmbeddable();
       const storage = new EmbeddableActionStorage(embeddable);

diff --git a/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.ts b/src/plugins/embeddable/public/lib/embeddables/embeddable_action_storage.ts
@@ -36,7 +36,6 @@ export class EmbeddableActionStorage implements UiActionsActionStorage {
     }
 
     this.embbeddable.updateInput({
-      ...input,
       events: [...events, event],
     });
   }
@@ -55,7 +54,6 @@ export class EmbeddableActionStorage implements UiActionsActionStorage {
     }
 
     this.embbeddable.updateInput({
-      ...input,
       events: [...events.slice(0, index), event, ...events.slice(index + 1)],
     });
   }
@@ -74,7 +72,6 @@ export class EmbeddableActionStorage implements UiActionsActionStorage {
     }
 
     this.embbeddable.updateInput({
-      ...input,
       events: [...events.slice(0, index), ...events.slice(index + 1)],
     });
   }