Address code review comments

elastic · Sep 18, 2024 · f89e476 · f89e476
1 parent 7f44356
commit f89e476
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 18 deletions.
diff --git a/...urity_solution/public/detection_engine/rule_management/components/rule_details/helpers.ts b/...urity_solution/public/detection_engine/rule_management/components/rule_details/helpers.ts
@@ -5,6 +5,7 @@
  * 2.0.
  */
 
+import { isPlainObject } from 'lodash';
 import type { Filter } from '@kbn/es-query';
 import type {
   DiffableAllFields,
@@ -77,10 +78,12 @@ export function getQueryLanguageLabel(language: string) {
 }
 
 /**
- * Assigns type `Filter[]` to an array if every item in has a `meta` property.
+ * Assigns type `Filter[]` to an array if every item in it has a `meta` property.
  */
 export function isFilters(maybeFilters: unknown[]): maybeFilters is Filter[] {
-  return maybeFilters.every((f) => typeof f === 'object' && f !== null && 'meta' in f);
+  return maybeFilters.every(
+    (f) => typeof f === 'object' && f !== null && 'meta' in f && isPlainObject(f.meta)
+  );
 }
 
 type DataSourceProps =

diff --git a/.../components/rule_details/three_way_diff/final_readonly/fields/description/description.tsx b/.../components/rule_details/three_way_diff/final_readonly/fields/description/description.tsx
@@ -10,14 +10,6 @@ import { EuiDescriptionList } from '@elastic/eui';
 import * as ruleDetailsI18n from '../../../../translations';
 import type { RuleDescription } from '../../../../../../../../../common/api/detection_engine';
 
-interface DescriptionProps {
-  description: RuleDescription;
-}
-
-function Description({ description }: DescriptionProps) {
-  return <>{description}</>;
-}
-
 interface DescriptionReadOnlyProps {
   description: RuleDescription;
 }
@@ -34,3 +26,11 @@ export function DescriptionReadOnly({ description }: DescriptionReadOnlyProps) {
     />
   );
 }
+
+interface DescriptionProps {
+  description: RuleDescription;
+}
+
+function Description({ description }: DescriptionProps) {
+  return <>{description}</>;
+}
diff --git a/...ule_management/components/rule_details/three_way_diff/final_readonly/fields/name/name.tsx b/...ule_management/components/rule_details/three_way_diff/final_readonly/fields/name/name.tsx
@@ -10,14 +10,6 @@ import { EuiDescriptionList } from '@elastic/eui';
 import * as ruleDetailsI18n from '../../../../translations';
 import type { RuleName } from '../../../../../../../../../common/api/detection_engine';
 
-interface NameProps {
-  name: RuleName;
-}
-
-function Name({ name }: NameProps) {
-  return <>{name}</>;
-}
-
 interface NameReadOnlyProps {
   name: RuleName;
 }
@@ -34,3 +26,11 @@ export function NameReadOnly({ name }: NameReadOnlyProps) {
     />
   );
 }
+
+interface NameProps {
+  name: RuleName;
+}
+
+function Name({ name }: NameProps) {
+  return <>{name}</>;
+}