Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower ES deprecation warning level to debug #120733

Closed
rudolf opened this issue Dec 8, 2021 · 2 comments
Closed

Lower ES deprecation warning level to debug #120733

rudolf opened this issue Dec 8, 2021 · 2 comments
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.0

Comments

@rudolf
Copy link
Contributor

rudolf commented Dec 8, 2021

In #120044 we introduced an elasticsearch.deprecation logger context that logs on info level if an Elasticsearch request from Kibana returns a warning header.

However, this can be confusing for users because they can't action these deprecations. It would be better to lower the log level to debug but then enable this logger by default on Cloud. Because the elasticsearch.deprecation logger also logs deprecations caused by user queries like from the console app it could cause a lot of log volume. So we should create two separate loggers: elasticsearch.deprecation.kibana and elasticsearch.deprecation.user

On cloud we would only enable debug logs for elasticsearch.deprecation.kibana by adding the following to the config template:

logging.loggers:
  - name: elasticsearch.deprecation.kibana
    level: all
@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.0 labels Dec 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf
Copy link
Contributor Author

rudolf commented Feb 23, 2022

Closed in #123660

Given the work done in #120043 I don't think it's necessary to enable debug logging on Cloud, we should rather catch deprecated API usage during our development cycle.

@rudolf rudolf closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.0
Projects
None yet
Development

No branches or pull requests

2 participants