Dashboard control data does not update when editing an existing control field

[liza-mae]

Kibana version: 8.4.3-SNAPSHOT

Elasticsearch version: 8.4.3-SNAPSHOT

Server OS version: Cloud / Staging

Browser version: Chrome / Latest

Original install method (e.g. download page, yum, from source, etc.):
Cloud staging

Description of the problem including expected versus actual behavior:
When updating an existing dashboard control field, the data is not loaded. You have to take another action to get it loaded, like refreshing the time picker.

Steps to reproduce:

1. Load sample data
2. Go to Dashboards -> Create new Dashboard
3. Add a control
4. Verify control is added and data is filled out
5. Edit control that was just added, update the field to another field. Notice the data is not loaded.

One way to work around the issue , is by clicking refresh.

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[Heenawter]

I tried to reproduce this locally and wasn't able to:

Screen.Recording.2022-09-21.at.12.47.54.PM.mov

Will try on a cloud instance and verify whether or not it works there 👍

[ThomThomson]

I was able to repro this on Elastic cloud 8.4.1 - very strange that it would work locally but not on cloud...

[ThomThomson]

I've given this impact:low because it only affects Dashboard authors at the moment, and it's fairly uncommon to change the field of a control.

[liza-mae]

Yea it is a regression from 8.3.3 looks like it broke in 8.4.0 -- I have a failing cloud test, so I am going to open to reference this issue for the test issue and skip the test on cloud so it does not fail in CI.

[Heenawter]

Tested this on cloud 8.4.1 instance and was also able to recreate it - very odd!

A few things I noticed:

1. This only seems to happen when switching from an options list to another options list field on edit - switching from range slider to options list or vice versa, this does not seem to happen.

2. Once a value is cached, it seems to work - i.e. suppose you edit a control that uses FieldA to now use FieldB - as noted in the bug, FieldB will initially display no results. Do not hit the refresh button, then edit the control to go back to FieldA and notice that FieldA still has results:

   Screen.Recording.2022-09-21.at.1.19.05.PM.mov

   If you, however, refresh on FieldB to get results instead, then return to FieldA, you will once again be in a no-data state for FieldA

   Screen.Recording.2022-09-21.at.1.20.13.PM.mov

[Heenawter]

This bug was present up to 8.4.3 - I tested this on Cloud for both 8.5.0 and 8.6.0 and was no longer able to recreate it:

Screen.Recording.2023-02-21.at.12.48.28.PM.mov

Not entirely sure what could have fixed this, because I went through all the controls-specific PRs that were merged in 8.5.0 and nothing stands out to me...

There was some major refactoring of the control group and the options list in 8.5.0, so it might somehow be related to that (although these shouldn't have had any use-facing changes...). Or perhaps something related to the race condition between the control group and the dashboard, although this seems to almost be a race condition in the opposite direction? Wish I had a more satisfying answer 😆 But, either way, this seems to be fixed - so, closing for now.

PR to unskip failed test to follow, once my flaky test runner passes 👍