Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Write e2e tests for how the edit rule button and the enable/disable toggle work for ML rules under different licenses and user privileges #143812

Open
maximpn opened this issue Oct 21, 2022 · 2 comments
Open

[Security Solution] Write e2e tests for how the edit rule button and the enable/disable toggle work for ML rules under different licenses and user privileges #143812

maximpn opened this issue Oct 21, 2022 · 2 comments
Assignees
@maximpn
Labels
Feature:ML Rule Security Solution Machine Learning rule type Feature:Rule Details Security Solution Detection Rule Details page Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test-coverage issues & PRs for improving code test coverage

Comments

@maximpn
Copy link
Contributor

maximpn commented Oct 21, 2022 •
edited by banderror
Loading

Depends on: #143932
Relates to: #143260, #143252

Summary

Cover #139796 and #143252 bug fixes with e2e tests.

Details

Generally speaking, we need e2e tests to cover the functionality under different user permissions and licenses. The implementation will require having helper functions to set up the proper state as well as the tests themselves. So this task splits the testing effort from the bugfixes and limits the scope.
@maximpn maximpn added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Oct 21, 2022
@maximpn maximpn self-assigned this Oct 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@maximpn maximpn mentioned this issue Oct 21, 2022
Merged
4 tasks
@banderror banderror changed the title [Security Solution] Cover edit rule button link by e2e tests [Security Solution] Write e2e tests for how the edit rule button and the enable/disable toggle work for ML rules under different licenses and user privileges Oct 25, 2022
@banderror banderror added test-coverage issues & PRs for improving code test coverage Feature:ML Rule Security Solution Machine Learning rule type Feature:Rule Management Security Solution Detection Rule Management area Feature:Rule Details Security Solution Detection Rule Details page labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximpn maximpn

Labels
Feature:ML Rule Security Solution Machine Learning rule type Feature:Rule Details Security Solution Detection Rule Details page Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test-coverage issues & PRs for improving code test coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximpn @banderror @elasticmachine