Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Fix issue with frequency.notify_when snake_case in API requests #148572

Closed
Zacqary opened this issue Jan 9, 2023 · 2 comments · Fixed by #148838
Closed

[RAM] Fix issue with frequency.notify_when snake_case in API requests #148572

Zacqary opened this issue Jan 9, 2023 · 2 comments · Fixed by #148838
Assignees
@Zacqary
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Jan 9, 2023

When moving frequency properties from the rule level to action level, we ran into an issue converting between camelCase and snake_case in nested parameters. This forced us to use frequency.notifyWhen as the only camelCased property in a rule create/update/etc. request.

Investigate exactly what's causing this issue and fix it.
@Zacqary Zacqary added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.7.0 labels Jan 9, 2023
@Zacqary Zacqary self-assigned this Jan 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@Zacqary Zacqary moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Rules & Alerts Management Jan 9, 2023
@Zacqary Zacqary mentioned this issue Jan 9, 2023
Merged
2 tasks
@Zacqary Zacqary mentioned this issue Jan 12, 2023
Merged
1 task
@guskovaue
Copy link
Contributor

@Zacqary How can I test it?

Zacqary added a commit that referenced this issue Jan 24, 2023
@Zacqary @guskovaue @kibanamachine
[RAM] Fix case conversion of frequency.notify_when in API (#148838)
cb2f07b 
## Summary

Closes #148572

Fixes an issue where rules APIs required `frequency.notifyWhen` to be
sent/received instead of `frequency.notify_when`


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Julia <iuliia.guskova@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAM] Fix case conversion of frequency.notify_when in API Zacqary/kibana
3 participants
@Zacqary @elasticmachine @guskovaue