-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Enhance layer presentation on Visualization modifiers popup #154349
Comments
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
Good catch. Ideally, I'd like to avoid a situation where we have to show multiple palettes to help users identify a single layer. I think it would distract too heavily from the purpose of this section in the popover (which is to inform users of the sampling percentage, not overwhelm them with color information). That said, I'm inclined to take one of two directions:
Thoughts on either of these approaches? CCing @stratoula, @ninoslavmiskovic, @timductive. |
Given the restricted context of the problem (only with datatable atm which supports only a single layer) I might propose to just not render the palette if the specific scenario is detected. Would that work for you @MichaelMarcialis ? |
I am fine with doing what Marco proposes for now. I think it is good to use the coloring as they indicate much better the sampled series. |
I also agree on using colours is the best approach, and also fine with @dej611 a short term proposal. I have previously used a multicoloured color swatch icon to indicate palettes. Perhaps that would be less noice and the design would align better. The color line as mentioned before triggers me GK click it because it is similar to the color palette selector. WDYT : @MichaelMarcialis Example : |
Great point. That works for me. Thanks, @dej611!
That's a very interesting idea, @ninoslavmiskovic! I instantly like it visually because of its compact nature and ability to align nicely with the solid color swatches (something the current color palette strip doesn't allow us to do). The only concern I'd have with such a direction is that it would be a bit more difficult for users to identify the individual colors being use, between the reduced size and the fact that it uses a radial gradient (which will ultimately show colors that aren't actually being represented in the visualization). If we're not worried about users identifying colors and just want to let them know that multiple colors are in use, I really like this direction. However, if we want users to be able to visually identify one or more colors being used in the visualization, this might prove problematic. Thoughts? |
@MichaelMarcialis - Can we add the color palette as a hover ? This way we inform the user on the colors ? |
That's an interesting idea! I'll play around with it for future iterations of this and also in the Lens layer panels (as the same pattern could theoretically be used there). |
## Summary Fix #154349 This PR introduces some chart info API enhancements, used within the visualization modifier popup in a embeddable context. <img width="596" alt="Screenshot 2023-04-19 at 15 56 01" src="https://user-images.githubusercontent.com/924948/233101058-9227511e-ee45-458f-93f7-249fb4c01ee8.png"> For the specific scenario with a table with multiple color by value columns, the palette is omitted: <img width="538" alt="Screenshot 2023-04-19 at 16 14 22" src="https://user-images.githubusercontent.com/924948/233103086-8908bd58-6632-4982-b33c-a6beb990fa75.png"> Sampling dashboard with many combinations: [sampling_testing_dashboard.ndjson.txt](https://github.com/elastic/kibana/files/11274000/sampling_testing_dashboard.ndjson.txt) Additional fixes: * 💄 Fixes bottom padding in case of single layer info in the popup Before: <img width="266" alt="Screenshot 2023-04-19 at 15 53 07 copy" src="https://user-images.githubusercontent.com/924948/233101455-7b34437c-1f2c-461e-98b3-8e245eacaa9a.png"> * 💄 Fixes some styling issues of the visualization modifier icon with some visualization types (treemaps, metrics, tables) Before: <img width="464" alt="Screenshot 2023-04-19 at 15 53 31" src="https://user-images.githubusercontent.com/924948/233102676-a988a186-ba0d-4237-b759-406c55f83c0d.png"> <img width="1176" alt="Screenshot 2023-04-19 at 15 53 17" src="https://user-images.githubusercontent.com/924948/233101680-5c1bcf7b-d369-4df4-9a5b-4c22a56fe06a.png"> <img width="266" alt="Screenshot 2023-04-19 at 15 53 07" src="https://user-images.githubusercontent.com/924948/233101686-414e0b31-1c9f-48da-8bfb-94567292cd98.png"> <img width="159" alt="Screenshot 2023-04-19 at 15 53 00" src="https://user-images.githubusercontent.com/924948/233101692-c76b7a0e-730a-4145-8688-720bd2602875.png"> <img width="222" alt="Screenshot 2023-04-19 at 15 52 44" src="https://user-images.githubusercontent.com/924948/233101694-66bdb977-37a1-421f-8ae4-5a7033c8d64a.png"> <img width="155" alt="Screenshot 2023-04-19 at 15 52 38" src="https://user-images.githubusercontent.com/924948/233101696-7d4152c1-5470-43ab-8120-27b0681b5078.png"> After: <img width="934" alt="Screenshot 2023-04-19 at 15 55 22" src="https://user-images.githubusercontent.com/924948/233101771-aaa25384-157d-488e-89d9-a8b138204408.png"> <img width="469" alt="Screenshot 2023-04-19 at 15 55 52" src="https://user-images.githubusercontent.com/924948/233101870-b8886e95-1d54-4467-aa32-6ef12aeb165e.png"> <img width="1184" alt="Screenshot 2023-04-19 at 15 55 45" src="https://user-images.githubusercontent.com/924948/233101874-418e56f7-098a-47a8-a4c1-9cf7fc7bd87a.png"> <img width="1184" alt="Screenshot 2023-04-19 at 15 55 38" src="https://user-images.githubusercontent.com/924948/233101877-35a02094-b749-4a82-85cf-ec573f911399.png"> <img width="934" alt="Screenshot 2023-04-19 at 15 55 31" src="https://user-images.githubusercontent.com/924948/233101878-7a9fcf41-f340-4beb-824e-e377771cfe54.png"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Describe the feature:
On Embeddable panels the new visualization modifier menu presents layers is a way that can be hard to distinguish when there are multiples.
Adding colour palettes should make it easier to distinguish them, as shown in this prototype:
The basic logic is:
The only missing case when multiple metric within a layer are using color by value: in this case multiple palettes can belong to a single layer... any idea about representing this case? Currently only table exposes this problem, so perhaps even no showing any color can be temporary ok.
cc @MichaelMarcialis
The text was updated successfully, but these errors were encountered: