Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard Navigation] Reference Inject / Extract #154363

Closed
Tracked by #154354
ThomThomson opened this issue Apr 4, 2023 · 2 comments
Closed
Tracked by #154354

[Dashboard Navigation] Reference Inject / Extract #154363

ThomThomson opened this issue Apr 4, 2023 · 2 comments
Assignees
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Description

The links stored in Dashboard navigation embeddables must be Hard links. This means that they properly store references to the linked dashboards in the source dashboard. In order for this to work properly, the navigation embeddable must implement inject / extract logic.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Dashboard Navigation Related to the Dashboard Navigation Project labels Apr 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

nickpeihl added a commit that referenced this issue Aug 31, 2023
Fixes #154363

## Summary

Extracts and injects references to Dashboards in Link panels to allow
sharing / importing to other Spaces.

To test this:

1. Create an empty dashboard.
1. Create a Links panel on the dashboard and save to library.
1. Save the dashboard as one or more new dashboards.
1. Update the Links panel with links to the new dashboards.
1. Create two new Spaces, "space1" and "space2" with the default
settings.
1. In Saved Objects, click the Actions button for your Links and choose
"Copy to Spaces".
1. Copy the Links to "space1".
1. Switch to the "space1" space and verify all the dashboards using that
Links panel were included.
1. In Saved Objects, select the Links saved object and export it
including all related objects
1. Switch to "space2" and import the Links saved object from the file
downloaded in the previous step.
1. Verify all the dashboards were also imported.
1. Inspect the saved object for the Links. The `references` array should
contain objects for each dashboard.
1. The `attributes.links[].destination` property should be a string in
the format of `links_<someuuid>_dashboard`. This string should match one
of the `references[].id`.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@nickpeihl
Copy link
Member

Fixed by #164330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants