Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard Navigation] Improve the empty state #161552

Closed
Tracked by #154354
Heenawter opened this issue Jul 10, 2023 · 7 comments · Fixed by #161605
Closed
Tracked by #154354

[Dashboard Navigation] Improve the empty state #161552

Heenawter opened this issue Jul 10, 2023 · 7 comments · Fixed by #161605
Assignees
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Describe the feature:

Right now, the empty state of the link panel is pretty bland:

image

As @nickpeihl brought up here, there is a lot that could be done to improve this empty state both through copy and, possibly, with a nice little graphic. @andreadelrio proposed the following for possible graphics:

Option 1 Option 2
image image

I am opening this issue so that we can have a more in-depth conversation about the options to improve this empty state without holding up the initial creation PR :)

@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Dashboard Navigation Related to the Dashboard Navigation Project labels Jul 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter changed the title [Dashboard Navigation] Improved empty state [Dashboard Navigation] Improve the empty state Jul 10, 2023
@Heenawter Heenawter added loe:medium Medium Level of Effort discuss and removed loe:small Small Level of Effort labels Jul 10, 2023
@Heenawter
Copy link
Contributor Author

Linking back to the original discussion, seems like we have three votes in favour of option 1 for the graphic. @teresaalvarezsoler What are your thoughts? 👀

Plus, tagging @gchaps here so that we move the discussion of copy to this issue :)

@teresaalvarezsoler
Copy link

I also prefer option 1 :) @Heenawter

@teresaalvarezsoler
Copy link

Btw, do we show "save to library" switcher if there are no links added yet?

@Heenawter
Copy link
Contributor Author

@teresaalvarezsoler Very good question! We could probably hide that toggle in the empty state - either that or, at minimum, it should be disabled with a tooltip describing that link panels must have at least one link to be saved. Hiding it is probably the best move IMO :)

@teresaalvarezsoler
Copy link

Yes, I think hiding will be better, thanks!

@Heenawter Heenawter added the Feature:Dashboard Dashboard related features label Jul 11, 2023
@Heenawter Heenawter removed the discuss label Jul 11, 2023
@Heenawter Heenawter linked a pull request Jul 11, 2023 that will close this issue
9 tasks
Heenawter pushed a commit that referenced this issue Jul 14, 2023
Closes #161552

## Summary

- Adds an illustration to the empty state in both light and dark mode.
- Updates copy as suggested by Gail.

### Updated design

<img width="450" alt="image"
src="https://github.com/elastic/kibana/assets/4016496/bccb709f-a553-483d-942a-e6dd5ffa0b26">

<img width="450" alt="image"
src="https://github.com/elastic/kibana/assets/4016496/b8f69218-911d-4a5a-9185-ed86a81ef652">



### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@Heenawter
Copy link
Contributor Author

Closed by #161605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants