-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution]Data view details twice in Rule Definition section #164828
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
@amolnater-qasource please review |
Reviewed & assigned to @MadameSheema |
Being addressed by @nikitaindik here - #164494 |
**Resolves: #164828 **Related UX writing issue: elastic/ux-writing#46 ## Summary In rule details page, when a rule has a data view selected, two labels show up as "Data View". This appears to be a bug, as one of those labels should be "Data view ID" and another should be "Data view index pattern". Thanks to @MadameSheema @nikitaindik for finding this. ### Before ![image](https://github.com/elastic/kibana/assets/10927944/8ac8b6d4-1005-4c03-a71a-31216a1287c5) ### After <img width="808" alt="Screenshot 2023-08-26 at 19 30 54" src="https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58"> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
**Resolves: elastic#164828 **Related UX writing issue: elastic/ux-writing#46 ## Summary In rule details page, when a rule has a data view selected, two labels show up as "Data View". This appears to be a bug, as one of those labels should be "Data view ID" and another should be "Data view index pattern". Thanks to @MadameSheema @nikitaindik for finding this. ### Before ![image](https://github.com/elastic/kibana/assets/10927944/8ac8b6d4-1005-4c03-a71a-31216a1287c5) ### After <img width="808" alt="Screenshot 2023-08-26 at 19 30 54" src="https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58"> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: Nikita Indik <nikita.indik@elastic.co> (cherry picked from commit 31e9557)
**Resolves: elastic#164828 **Related UX writing issue: elastic/ux-writing#46 In rule details page, when a rule has a data view selected, two labels show up as "Data View". This appears to be a bug, as one of those labels should be "Data view ID" and another should be "Data view index pattern". Thanks to @MadameSheema @nikitaindik for finding this. ![image](https://github.com/elastic/kibana/assets/10927944/8ac8b6d4-1005-4c03-a71a-31216a1287c5) <img width="808" alt="Screenshot 2023-08-26 at 19 30 54" src="https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58"> - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: Nikita Indik <nikita.indik@elastic.co> (cherry picked from commit 31e9557)
… (#165015) # Backport This will backport the following commits from `main` to `8.10`: - [[Rule Details] - Update rule details data view id text (#164494)](#164494) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-28T16:29:00Z","message":"[Rule Details] - Update rule details data view id text (#164494)\n\n**Resolves: https://github.com/elastic/kibana/issues/164828**\r\n**Related UX writing issue:\r\nhttps://github.com/elastic/ux-writing/issues/46**\r\n\r\n## Summary\r\n\r\nIn rule details page, when a rule has a data view selected, two labels\r\nshow up as \"Data View\". This appears to be a bug, as one of those labels\r\nshould be \"Data view ID\" and another should be \"Data view index\r\npattern\".\r\n\r\nThanks to @MadameSheema @nikitaindik for finding this. \r\n\r\n### Before \r\n\r\n![image](https://github.com/elastic/kibana/assets/10927944/8ac8b6d4-1005-4c03-a71a-31216a1287c5)\r\n\r\n### After\r\n<img width=\"808\" alt=\"Screenshot 2023-08-26 at 19 30 54\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>","sha":"31e95574ae6d8cfa9e0ba4595e1068e9391b423d","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Detection Rule Management","ui-copy","Feature:Rule Details","Team:Detection Engine","v8.10.0","v8.11.0","v8.9.2"],"number":164494,"url":"https://github.com/elastic/kibana/pull/164494","mergeCommit":{"message":"[Rule Details] - Update rule details data view id text (#164494)\n\n**Resolves: https://github.com/elastic/kibana/issues/164828**\r\n**Related UX writing issue:\r\nhttps://github.com/elastic/ux-writing/issues/46**\r\n\r\n## Summary\r\n\r\nIn rule details page, when a rule has a data view selected, two labels\r\nshow up as \"Data View\". This appears to be a bug, as one of those labels\r\nshould be \"Data view ID\" and another should be \"Data view index\r\npattern\".\r\n\r\nThanks to @MadameSheema @nikitaindik for finding this. \r\n\r\n### Before \r\n\r\n![image](https://github.com/elastic/kibana/assets/10927944/8ac8b6d4-1005-4c03-a71a-31216a1287c5)\r\n\r\n### After\r\n<img width=\"808\" alt=\"Screenshot 2023-08-26 at 19 30 54\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>","sha":"31e95574ae6d8cfa9e0ba4595e1068e9391b423d"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164494","number":164494,"mergeCommit":{"message":"[Rule Details] - Update rule details data view id text (#164494)\n\n**Resolves: https://github.com/elastic/kibana/issues/164828**\r\n**Related UX writing issue:\r\nhttps://github.com/elastic/ux-writing/issues/46**\r\n\r\n## Summary\r\n\r\nIn rule details page, when a rule has a data view selected, two labels\r\nshow up as \"Data View\". This appears to be a bug, as one of those labels\r\nshould be \"Data view ID\" and another should be \"Data view index\r\npattern\".\r\n\r\nThanks to @MadameSheema @nikitaindik for finding this. \r\n\r\n### Before \r\n\r\n![image](https://github.com/elastic/kibana/assets/10927944/8ac8b6d4-1005-4c03-a71a-31216a1287c5)\r\n\r\n### After\r\n<img width=\"808\" alt=\"Screenshot 2023-08-26 at 19 30 54\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>","sha":"31e95574ae6d8cfa9e0ba4595e1068e9391b423d"}},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
#165021) # Backport This will backport the following commits from `main` to `8.9`: - [[Rule Details] - Update rule details data view id text (#164494)](#164494) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-28T16:29:00Z","message":"[Rule Details] - Update rule details data view id text (#164494)\n\n**Resolves: https://github.com/elastic/kibana/issues/164828**\r\n**Related UX writing issue:\r\nhttps://github.com/elastic/ux-writing/issues/46**\r\n\r\n## Summary\r\n\r\nIn rule details page, when a rule has a data view selected, two labels\r\nshow up as \"Data View\". This appears to be a bug, as one of those labels\r\nshould be \"Data view ID\" and another should be \"Data view index\r\npattern\".\r\n\r\nThanks to @MadameSheema @nikitaindik for finding this. \r\n\r\n### Before \r\n\r\n![image](https://github.com/elastic/kibana/assets/10927944/8ac8b6d4-1005-4c03-a71a-31216a1287c5)\r\n\r\n### After\r\n<img width=\"808\" alt=\"Screenshot 2023-08-26 at 19 30 54\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>","sha":"31e95574ae6d8cfa9e0ba4595e1068e9391b423d","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Detection Rule Management","ui-copy","Feature:Rule Details","Team:Detection Engine","v8.10.0","v8.11.0","v8.9.2"],"number":164494,"url":"https://github.com/elastic/kibana/pull/164494","mergeCommit":{"message":"[Rule Details] - Update rule details data view id text (#164494)\n\n**Resolves: https://github.com/elastic/kibana/issues/164828**\r\n**Related UX writing issue:\r\nhttps://github.com/elastic/ux-writing/issues/46**\r\n\r\n## Summary\r\n\r\nIn rule details page, when a rule has a data view selected, two labels\r\nshow up as \"Data View\". This appears to be a bug, as one of those labels\r\nshould be \"Data view ID\" and another should be \"Data view index\r\npattern\".\r\n\r\nThanks to @MadameSheema @nikitaindik for finding this. \r\n\r\n### Before \r\n\r\n![image](https://github.com/elastic/kibana/assets/10927944/8ac8b6d4-1005-4c03-a71a-31216a1287c5)\r\n\r\n### After\r\n<img width=\"808\" alt=\"Screenshot 2023-08-26 at 19 30 54\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>","sha":"31e95574ae6d8cfa9e0ba4595e1068e9391b423d"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/165015","number":165015,"state":"OPEN"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164494","number":164494,"mergeCommit":{"message":"[Rule Details] - Update rule details data view id text (#164494)\n\n**Resolves: https://github.com/elastic/kibana/issues/164828**\r\n**Related UX writing issue:\r\nhttps://github.com/elastic/ux-writing/issues/46**\r\n\r\n## Summary\r\n\r\nIn rule details page, when a rule has a data view selected, two labels\r\nshow up as \"Data View\". This appears to be a bug, as one of those labels\r\nshould be \"Data view ID\" and another should be \"Data view index\r\npattern\".\r\n\r\nThanks to @MadameSheema @nikitaindik for finding this. \r\n\r\n### Before \r\n\r\n![image](https://github.com/elastic/kibana/assets/10927944/8ac8b6d4-1005-4c03-a71a-31216a1287c5)\r\n\r\n### After\r\n<img width=\"808\" alt=\"Screenshot 2023-08-26 at 19 30 54\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/b511bf92-0e90-4455-834c-36b8e75b2a58\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Nikita Indik <nikita.indik@elastic.co>","sha":"31e95574ae6d8cfa9e0ba4595e1068e9391b423d"}},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Pending to be validated. |
Screenshots: Screen recording: Data.view.and.rule.definition.mp4@MadameSheema FYI QA Validation ✅ |
We have validated this issue on 8.10 BC3 and found the issue to be fixed now ✔️ . Kibana/Elasticsearch Stack version
Screen-Cast: Hence we are closing this issue and adding "QA:Validated" tag to it. thanks !! |
We have validated this issue on 8.9.2 BC1 and found the issue to be fixed now ✔️ . Kibana/Elasticsearch Stack version Screen-Shot: Hence we are closing this issue and adding "QA:Validated" tag to it. thanks !! |
Describe the bug:
Data view details twice in Rule Definition section
Kibana/Elasticsearch Stack version
Version: 8.10.0 BC2
Commit: fa3473f
Build: 66107
Browser and Browser OS Version:
Firefox for windows OS
Version: 116.0.3
Elastic Endpoint Version:
v8.10.2
Original install method:
Build summary: https://staging.elastic.co/8.10.0-049269aa/summary-8.10.0.html
Functional Area:
Data View Rule
Initial Setup:
Steps to reproduce
Additional Observation
Current behavior
Expected behavior:
Screen-Shot:
Errors in browser console:
None
Any additional context (logs, chat logs, magical formulas, etc.):
None
The text was updated successfully, but these errors were encountered: