-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: Serverless Observability Examples Functional Tests.x-pack/test_serverless/functional/test_suites/common/examples/search/warnings·ts - serverless examples UI Search examples handling warnings with search source fetch "after all" hook for "able to handle shard failure warnings and prevent default notifications" #165624
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
Skipped. main: ec3b875 |
Normal test: - Closes #139879 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3056 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3070 Similar Serverless tests: - #165660 - #165624 - #165623 - #165503 - #165502 - #165379 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Normal test: - Closes elastic#139879 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3056 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3070 Similar Serverless tests: - elastic#165660 - elastic#165624 - elastic#165623 - elastic#165503 - elastic#165502 - elastic#165379 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6d79b67) # Conflicts: # x-pack/test_serverless/functional/test_suites/common/examples/search/warnings.ts # x-pack/test_serverless/tsconfig.json
…165932) # Backport This will backport the following commits from `main` to `8.10`: - [[Discover] Unskip "search source fetch" flaky tests (#165586)](#165586) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-09-07T05:57:32Z","message":"[Discover] Unskip \"search source fetch\" flaky tests (#165586)\n\nNormal test:\r\n- Closes https://github.com/elastic/kibana/issues/139879\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3056\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3070\r\n\r\nSimilar Serverless tests:\r\n- https://github.com/elastic/kibana/issues/165660\r\n- https://github.com/elastic/kibana/issues/165624\r\n- https://github.com/elastic/kibana/issues/165623\r\n- https://github.com/elastic/kibana/issues/165503\r\n- https://github.com/elastic/kibana/issues/165502\r\n- https://github.com/elastic/kibana/issues/165379\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"6d79b6751dbb345c477e542dfd222e5ac222d6b5","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.11.0"],"number":165586,"url":"https://github.com/elastic/kibana/pull/165586","mergeCommit":{"message":"[Discover] Unskip \"search source fetch\" flaky tests (#165586)\n\nNormal test:\r\n- Closes https://github.com/elastic/kibana/issues/139879\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3056\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3070\r\n\r\nSimilar Serverless tests:\r\n- https://github.com/elastic/kibana/issues/165660\r\n- https://github.com/elastic/kibana/issues/165624\r\n- https://github.com/elastic/kibana/issues/165623\r\n- https://github.com/elastic/kibana/issues/165503\r\n- https://github.com/elastic/kibana/issues/165502\r\n- https://github.com/elastic/kibana/issues/165379\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"6d79b6751dbb345c477e542dfd222e5ac222d6b5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165586","number":165586,"mergeCommit":{"message":"[Discover] Unskip \"search source fetch\" flaky tests (#165586)\n\nNormal test:\r\n- Closes https://github.com/elastic/kibana/issues/139879\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3056\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3070\r\n\r\nSimilar Serverless tests:\r\n- https://github.com/elastic/kibana/issues/165660\r\n- https://github.com/elastic/kibana/issues/165624\r\n- https://github.com/elastic/kibana/issues/165623\r\n- https://github.com/elastic/kibana/issues/165503\r\n- https://github.com/elastic/kibana/issues/165502\r\n- https://github.com/elastic/kibana/issues/165379\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"6d79b6751dbb345c477e542dfd222e5ac222d6b5"}}]}] BACKPORT-->
I'm removing the |
) ## Summary This PR unskips and fixes the remaining flaky Serverless examples tests. Resolves #165730. Resolves #165735. Resolves #165624. Resolves #165623. Resolves #165635. Resolves #165938. Resolves #165927. Resolves #165882. Resolves #165797. Resolves #167939. Resolves #165503. Resolves #165502. Resolves #165379. Flaky test runs: - x300: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3430 🟢 - x300: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3455 🔴 - x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3478 🟢 ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…tic#168422) ## Summary This PR unskips and fixes the remaining flaky Serverless examples tests. Resolves elastic#165730. Resolves elastic#165735. Resolves elastic#165624. Resolves elastic#165623. Resolves elastic#165635. Resolves elastic#165938. Resolves elastic#165927. Resolves elastic#165882. Resolves elastic#165797. Resolves elastic#167939. Resolves elastic#165503. Resolves elastic#165502. Resolves elastic#165379. Flaky test runs: - x300: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3430 🟢 - x300: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3455 🔴 - x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3478 🟢 ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 8bd40bc) # Conflicts: # x-pack/test_serverless/functional/test_suites/common/examples/search_examples/search_example.ts
#168422) (#168664) # Backport This will backport the following commits from `main` to `8.11`: - [[Data Discovery] Unskip and fix flaky Serverless examples tests (#168422)](#168422) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2023-10-12T02:19:45Z","message":"[Data Discovery] Unskip and fix flaky Serverless examples tests (#168422)\n\n## Summary\r\n\r\nThis PR unskips and fixes the remaining flaky Serverless examples tests.\r\n\r\nResolves #165730.\r\nResolves #165735.\r\nResolves #165624.\r\nResolves #165623.\r\nResolves #165635.\r\nResolves #165938.\r\nResolves #165927.\r\nResolves #165882.\r\nResolves #165797.\r\nResolves #167939.\r\nResolves #165503.\r\nResolves #165502.\r\nResolves #165379.\r\n\r\nFlaky test runs:\r\n- x300:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3430\r\n🟢\r\n- x300:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3455\r\n🔴\r\n- x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3478\r\n🟢\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8bd40bcfb782c5a2b9258c41cf7fe3cdedfcb69d","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","v8.11.0","v8.12.0"],"number":168422,"url":"https://github.com/elastic/kibana/pull/168422","mergeCommit":{"message":"[Data Discovery] Unskip and fix flaky Serverless examples tests (#168422)\n\n## Summary\r\n\r\nThis PR unskips and fixes the remaining flaky Serverless examples tests.\r\n\r\nResolves #165730.\r\nResolves #165735.\r\nResolves #165624.\r\nResolves #165623.\r\nResolves #165635.\r\nResolves #165938.\r\nResolves #165927.\r\nResolves #165882.\r\nResolves #165797.\r\nResolves #167939.\r\nResolves #165503.\r\nResolves #165502.\r\nResolves #165379.\r\n\r\nFlaky test runs:\r\n- x300:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3430\r\n🟢\r\n- x300:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3455\r\n🔴\r\n- x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3478\r\n🟢\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8bd40bcfb782c5a2b9258c41cf7fe3cdedfcb69d"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168422","number":168422,"mergeCommit":{"message":"[Data Discovery] Unskip and fix flaky Serverless examples tests (#168422)\n\n## Summary\r\n\r\nThis PR unskips and fixes the remaining flaky Serverless examples tests.\r\n\r\nResolves #165730.\r\nResolves #165735.\r\nResolves #165624.\r\nResolves #165623.\r\nResolves #165635.\r\nResolves #165938.\r\nResolves #165927.\r\nResolves #165882.\r\nResolves #165797.\r\nResolves #167939.\r\nResolves #165503.\r\nResolves #165502.\r\nResolves #165379.\r\n\r\nFlaky test runs:\r\n- x300:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3430\r\n🟢\r\n- x300:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3455\r\n🔴\r\n- x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3478\r\n🟢\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8bd40bcfb782c5a2b9258c41cf7fe3cdedfcb69d"}}]}] BACKPORT-->
…tic#168422) ## Summary This PR unskips and fixes the remaining flaky Serverless examples tests. Resolves elastic#165730. Resolves elastic#165735. Resolves elastic#165624. Resolves elastic#165623. Resolves elastic#165635. Resolves elastic#165938. Resolves elastic#165927. Resolves elastic#165882. Resolves elastic#165797. Resolves elastic#167939. Resolves elastic#165503. Resolves elastic#165502. Resolves elastic#165379. Flaky test runs: - x300: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3430 🟢 - x300: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3455 🔴 - x100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3478 🟢 ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
A test failed on a tracked branch
First failure: CI Build - main
The text was updated successfully, but these errors were encountered: