Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/open_in_lens/tsvb/dashboard·ts - lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by reference TSVB viz to a Lens viz #179307

Closed
kibanamachine opened this issue Mar 23, 2024 · 30 comments · Fixed by #179858, #180606 or #190230
Closed

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/open_in_lens/tsvb/dashboard·ts - lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by reference TSVB viz to a Lens viz #179307

kibanamachine opened this issue Mar 23, 2024 · 30 comments · Fixed by #179858, #180606 or #190230
Assignees
@dej611
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 23, 2024 •
edited by markov00
Loading

A test failed on a tracked branch

Error: retry.try reached timeout 120000 ms
Error: retry.try reached timeout 120000 ms
TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="saveCustomizePanelButton"])
Wait timed out after 10047ms
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-7f68d90c3e21ccca/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:910:22
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:84:7)
    at RetryService.try (retry.ts:51:12)
    at Proxy.clickByCssSelector (find.ts:419:5)
    at TestSubjects.click (test_subjects.ts:164:5)
    at panel_settings.ts:155:9
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:98:21)
    at RetryService.try (retry.ts:51:12)
    at DashboardCustomizePanel.clickSaveButton (panel_settings.ts:153:7)
    at Context.<anonymous> (dashboard.ts:96:7)
    at Object.apply (wrap_function.js:73:16)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:84:7)
    at RetryService.try (retry.ts:51:12)
    at DashboardCustomizePanel.clickSaveButton (panel_settings.ts:153:7)
    at Context.<anonymous> (dashboard.ts:96:7)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main

The current since 2024-11-29 error is not anymore the one shown above, but:

ail: lens app - TSVB Open in Lens Dashboard to TSVB to Lens should convert a by reference TSVB viz to a Lens viz
[00:02:17]         │      Error: expected 'My TSVB to Lens viz 2' to equal 'My TSVB to Lens viz 2 (converted)'
[00:02:17]         │       at Assertion.assert (expect.js:100:11)
[00:02:17]         │       at Assertion.apply (expect.js:227:8)
[00:02:17]         │       at Assertion.be (expect.js:69:22)
[00:02:17]         │       at Context.<anonymous> (dashboard.ts:118:28)
[00:02:17]         │       at processTicksAndRejections (node:internal/process/task_queues:95:5)
[00:02:17]         │       at Object.apply (wrap_function.js:74:16)
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Mar 23, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 23, 2024
@kibanamachine kibanamachine added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 23, 2024
@stratoula
Copy link
Contributor

Closing as is the first time it fails

@kibanamachine kibanamachine reopened this Mar 24, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Apr 1, 2024
@mistic
skip flaky suite (#179307)
13dfd58
@mistic
Copy link
Member

mistic commented Apr 1, 2024

Skipped.

main: 13dfd58

@dej611 dej611 self-assigned this Apr 2, 2024
@dej611 dej611 mentioned this issue Apr 2, 2024
Merged
1 task
dej611 added a commit that referenced this issue Apr 4, 2024
@dej611
Unskip TSVB to Lens functional test (#179858)
d680d2d 
## Summary

Fixes #179307 and speeds up a bit the `resetPage` method when possible
via click on the `Visualize list` navigation breadcrumb on the top left:

<img width="289" alt="Screenshot 2024-04-04 at 09 56 37"
src="https://github.com/elastic/kibana/assets/924948/74011b51-34b1-4cfa-a78e-4224a3494a25">


The work on `navigateToNewVisualization` (function called by
`resetPage`) had some side effects for some tests where a uiSettings
changes were used as shortcut for the time picker: in such case a
`forceRefresh` option has been provided now to cover it, but I may
suggest to reduce the usage as much as possible.
The new change lead to an average of ~5 minutes saving only within the
`open_in_lens/tsvb` test suite, but it is a rough number as the average
between the savings on the CI on the flaky runner.
Probably there's an extra saving on other test suites as well.

Flaky runner for the `Open in Lens/TSVB` test suite (50x runs):
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5604
Flaky runner for the `Lens - Group5` test suite (50x runs):
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5606#_


### Checklist


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@kibanamachine kibanamachine reopened this Apr 8, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@dej611
Copy link
Contributor

dej611 commented Apr 8, 2024

Closing for now, but will check again after another failure.

@dej611 dej611 closed this as completed Apr 8, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine kibanamachine reopened this Apr 10, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@mbondyra mbondyra mentioned this issue Aug 27, 2024
Merged
mbondyra added a commit that referenced this issue Aug 27, 2024
@mbondyra
[Managed Content] fix flaky tests (#191388)
2a033c1 
## Summary

Fixes #190227

Fixes #190737
#190990
#190802
#179307 (couldn't find the
rootcause so just decided to align the solution with other files that
follow similar path and are not flaky)

Fixes #191151
#191152
#191176
#191177
#191178
#191153
#191238

Fixes #190711
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 27, 2024
@mbondyra
[Managed Content] fix flaky tests (elastic#191388)
d062a5f 
## Summary

Fixes elastic#190227

Fixes elastic#190737
elastic#190990
elastic#190802
elastic#179307 (couldn't find the
rootcause so just decided to align the solution with other files that
follow similar path and are not flaky)

Fixes elastic#191151
elastic#191152
elastic#191176
elastic#191177
elastic#191178
elastic#191153
elastic#191238

Fixes elastic#190711

(cherry picked from commit 2a033c1)
@kibanamachine kibanamachine reopened this Nov 27, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-snapshot-verify - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-snapshot-verify - main

mistic added a commit that referenced this issue Nov 27, 2024
@mistic
skip flaky suite (#179307)
40fa231
@mistic
Copy link
Member

mistic commented Nov 27, 2024

Skipped.

main: 40fa231

@markov00 markov00 assigned markov00 and unassigned mbondyra Nov 29, 2024
@markov00 markov00 mentioned this issue Nov 29, 2024
Merged
1 task
@markov00 markov00 assigned dej611 and unassigned markov00 Nov 29, 2024
dej611 added a commit that referenced this issue Nov 29, 2024
@dej611
[Lens] Unskip "Dashboard to TSVB to Lens" serverless test (#202275)
2ed1fdf 
## Summary
Fixes: #190737, #190802, #190990, #179307

This test started failing after @nreese Reset PR was merged here:
#201687 and the Lens embeddable
refactor PR introducing a regression which affected the test.
Later on the PR was reverted with
#201902 .


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@markov00
Copy link
Member

closed in #202275

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
@dej611 @CAWilson94
[Lens] Unskip "Dashboard to TSVB to Lens" serverless test (elastic#20…
a04e24c 
…2275)

## Summary
Fixes: elastic#190737, elastic#190802, elastic#190990, elastic#179307

This test started failing after @nreese Reset PR was merged here:
elastic#201687 and the Lens embeddable
refactor PR introducing a regression which affected the test.
Later on the PR was reverted with
elastic#201902 .


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dej611 dej611

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
7 participants
@dej611 @markov00 @mbondyra @mistic @elasticmachine @stratoula @kibanamachine