Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Include inactive status in agent table status counts #181042

Closed
philippkahr opened this issue Apr 17, 2024 · 4 comments · Fixed by #191535
Closed

[Fleet] Include inactive status in agent table status counts #181042

philippkahr opened this issue Apr 17, 2024 · 4 comments · Fixed by #191535
Assignees
@jen-huang
Labels
Team:Fleet Team label for Observability Data Collection Fleet team UX

Comments

@philippkahr
Copy link
Contributor

Describe the feature:

Describe a specific use case for the feature:
Can we have that status list bar, with the 3 healthy, unhealthy 0, inactive 52. Always, regardless of the status selection I do for the filtering?

image
image (2)
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 17, 2024
@juliaElastic juliaElastic added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 17, 2024
@juliaElastic
Copy link
Contributor

This suggestion came up from a discussion that it's hard to notice that there are inactive agents, unless we select the inactive filter manually. I agree that we could improve the UX to make inactive agents more noticeable.

@kpollich
Copy link
Member

I think this is fairly straightforward and approachable. Scheduling for next sprint.

@kpollich kpollich changed the title Value list bar above table for Elastic Agent in Fleet overview lists "healthy, ..." per default it should also include "inactive" [Fleet] Value list bar above table for Elastic Agent in Fleet overview lists "healthy, ..." per default it should also include "inactive" Jul 27, 2024
@kpollich kpollich changed the title [Fleet] Value list bar above table for Elastic Agent in Fleet overview lists "healthy, ..." per default it should also include "inactive" [Fleet] Include inactive status in agent table status counts Jul 27, 2024
@jen-huang jen-huang mentioned this issue Aug 27, 2024
Merged
@jen-huang
Copy link
Contributor

As discussed during sprint kickoff, we decided that the scope of this enhancement is to simply show all the available statuses in this status bar for discoverability. PR #191535 does this work.

The scope does NOT make it so that the status counts ignore the actual status filtering.

jen-huang added a commit that referenced this issue Aug 28, 2024
@jen-huang
[UII] Always show inactive and offline statuses in agent status bar (#…
6b6bb3c 
…191535)

## Summary

Resolves #181042. This PR makes it so that `Offline` and `Inactive`
statuses are always shown in the agent status bar even if their counts
are 0, so that they are more discoverable.

<img width="1115" alt="image"
src="https://github.com/user-attachments/assets/97fb7609-34b8-411a-950d-105902553d0e">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 28, 2024
@jen-huang
[UII] Always show inactive and offline statuses in agent status bar (e…
cb1a8ad 
…lastic#191535)

## Summary

Resolves elastic#181042. This PR makes it so that `Offline` and `Inactive`
statuses are always shown in the agent status bar even if their counts
are 0, so that they are more discoverable.

<img width="1115" alt="image"
src="https://github.com/user-attachments/assets/97fb7609-34b8-411a-950d-105902553d0e">

(cherry picked from commit 6b6bb3c)
kibanamachine added a commit that referenced this issue Aug 28, 2024
@kibanamachine @jen-huang
[8.15] [UII] Always show inactive and offline statuses in agent statu…
e141dc4 
…s bar (#191535) (#191657)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[UII] Always show inactive and offline statuses in agent status bar
(#191535)](#191535)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jen
Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2024-08-28T15:43:26Z","message":"[UII]
Always show inactive and offline statuses in agent status bar
(#191535)\n\n## Summary\r\n\r\nResolves #181042. This PR makes it so
that `Offline` and `Inactive`\r\nstatuses are always shown in the agent
status bar even if their counts\r\nare 0, so that they are more
discoverable.\r\n\r\n<img width=\"1115\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/97fb7609-34b8-411a-950d-105902553d0e\">","sha":"6b6bb3cfe056e0bf6a721709e43dc1b336e7f624","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.16.0"],"title":"[UII]
Always show inactive and offline statuses in agent status
bar","number":191535,"url":"https://github.com/elastic/kibana/pull/191535","mergeCommit":{"message":"[UII]
Always show inactive and offline statuses in agent status bar
(#191535)\n\n## Summary\r\n\r\nResolves #181042. This PR makes it so
that `Offline` and `Inactive`\r\nstatuses are always shown in the agent
status bar even if their counts\r\nare 0, so that they are more
discoverable.\r\n\r\n<img width=\"1115\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/97fb7609-34b8-411a-950d-105902553d0e\">","sha":"6b6bb3cfe056e0bf6a721709e43dc1b336e7f624"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191535","number":191535,"mergeCommit":{"message":"[UII]
Always show inactive and offline statuses in agent status bar
(#191535)\n\n## Summary\r\n\r\nResolves #181042. This PR makes it so
that `Offline` and `Inactive`\r\nstatuses are always shown in the agent
status bar even if their counts\r\nare 0, so that they are more
discoverable.\r\n\r\n<img width=\"1115\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/97fb7609-34b8-411a-950d-105902553d0e\">","sha":"6b6bb3cfe056e0bf6a721709e43dc1b336e7f624"}}]}]
BACKPORT-->

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jen-huang jen-huang

Labels
Team:Fleet Team label for Observability Data Collection Fleet team UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UII] Always show inactive and offline statuses in agent status bar jen-huang/kibana
5 participants
@jen-huang @kpollich @philippkahr @elasticmachine @juliaElastic