Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES|QL mode shows extra entries in Inspector #188266

Closed
lukasolson opened this issue Jul 12, 2024 · 4 comments · Fixed by #191232
Closed

ES|QL mode shows extra entries in Inspector #188266

lukasolson opened this issue Jul 12, 2024 · 4 comments · Fixed by #191232
Assignees
@lukasolson
Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana

Comments

@lukasolson
Copy link
Member

lukasolson commented Jul 12, 2024 •
edited by stratoula
Loading

Kibana version: 8.16.0-SNAPSHOT

Elasticsearch version: 8.16.0-SNAPSHOT

Describe the bug:

In ES|QL mode, with a query that takes longer than 200ms, multiple entries show up in the Inspector.

Steps to reproduce:

  1. Apply this patch.txt to simulate a slow query (modify the name: 'logs-*', portion to match the index pattern you intend to query)
  2. Open Discover & switch to ES|QL mode
  3. Submit a query to the index pattern you used in step 1.

The query will take at least 5 seconds to complete. When it does, it will show multiple entries inside inspector for both the Table and Visualization:

image

Expected behavior:

Only one entry each for the Table & Visualization queries (like it is in data view mode).

Any additional context:

It looks like we're actually showing an entry in Inspector for each HTTP request. For example, if I have a query that runs for 5 seconds in Elasticsearch, we're actually making 1 HTTP request to submit the query, and then 5 HTTP polling requests, which results in 6 entries instead of just one.
@lukasolson lukasolson added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Jul 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Jul 15, 2024
@stratoula stratoula changed the title ES|QL mode shows extra entries in Inspector and inaccurate durations in recent queries view ES|QL mode shows extra entries in Inspector Jul 16, 2024
@davismcphee
Copy link
Contributor

Related: #187051

@lukasolson lukasolson mentioned this issue Aug 23, 2024
Merged
2 tasks
lukasolson added a commit that referenced this issue Aug 29, 2024
@lukasolson
[ES|QL] Only log requests to Inspector on request complete (#191232)
c71c0df 
## Summary

Requires #191520.
Resolves #188266.

Prior to this PR, when polling on an async ES|QL request, we would log
the response to every polling request. This PR only logs when the
request is complete.

Before:


![image](https://github.com/user-attachments/assets/fe9a763d-ef43-4f46-a096-0e08e1805f47)

After:


![image](https://github.com/user-attachments/assets/5d59f016-8b0e-4a3f-b044-17b5de97739f)


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
([build](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6823))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasolson lukasolson

Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] Only log requests to Inspector on request complete lukasolson/kibana
5 participants
@kertal @lukasolson @elasticmachine @stratoula @davismcphee