Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable Rebuild] Keep panel title in sync with saved object title #188858

Open
Heenawter opened this issue Jul 22, 2024 · 1 comment
Open

[Embeddable Rebuild] Keep panel title in sync with saved object title #188858

Heenawter opened this issue Jul 22, 2024 · 1 comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Describe the bug:
With React embeddables, we are always serializing the panel title even if it is equal to the default panel title / saved object title.

Steps to reproduce:

  1. Add a by-reference Map embeddable to your dashboard - keep the default panel title.
  2. Edit that Map saved object's title
  3. Go back to the dashboard
  4. The Map panel still shows the original title and not the updated one 🔥

Expected behavior:
When the panel title is not overwritten and it is equal to the default panel title, it should not be serialized.

Screenshots (if relevant):

Screen.Recording.2024-07-22.at.9.23.31.AM.mov
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. project:embeddableRebuild labels Jul 22, 2024
@Heenawter Heenawter self-assigned this Jul 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter mentioned this issue Jul 22, 2024
Merged
4 tasks
@Heenawter Heenawter removed their assignment Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Heenawter @elasticmachine