Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] variables are suggested over and over in field lists #191100

Closed
drewdaemon opened this issue Aug 22, 2024 · 1 comment · Fixed by #195679
Closed

[ES|QL] variables are suggested over and over in field lists #191100

drewdaemon opened this issue Aug 22, 2024 · 1 comment · Fixed by #195679
Assignees
@drewdaemon
Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana

Comments

@drewdaemon
Copy link
Contributor

Kibana version:
8.15.0

Screen.Recording.2024-08-22.at.9.06.50.AM.mov
@drewdaemon drewdaemon added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Aug 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

This was referenced Aug 22, 2024
Merged
Closed
drewdaemon added a commit that referenced this issue Aug 23, 2024
@drewdaemon
[ES|QL] Auto open suggestions for field lists (#190466)
15ef37f 
## Summary

Part of #189662

## Suggests comma and pipe


https://github.com/user-attachments/assets/c09bc6fd-20a6-4f42-a871-c70e68e6d81a

## Doesn't suggest comma when there are no more fields


https://github.com/user-attachments/assets/29fce13e-e58b-4d93-bce5-6b1f913b4d92

## Doesn't work for escaped columns :(


https://github.com/user-attachments/assets/3d65f3b9-923d-4c0e-9c50-51dd83115c8b

As part of this effort I discovered
#191100 and
#191105, as well as a problem
with column name validation (see
#177699)

I think we can revisit column escaping and probably resolve all of these
issues (issue [here](#191111)).


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@drewdaemon drewdaemon mentioned this issue Oct 9, 2024
Merged
1 task
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 10, 2024
@drewdaemon
[ES|QL] only suggest pipe at the end of the field list (elastic#195679)
4d13a92 
## Summary

Close elastic#191100

### Improvements

1. You no longer get a comma suggestion when you're out of fields...

https://github.com/user-attachments/assets/3ed3617b-99e2-44a5-917e-294b98f16ef4

2. Fixed elastic#191100

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit dffe0b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewdaemon drewdaemon

Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] only suggest pipe at the end of the field list drewdaemon/kibana
2 participants
@drewdaemon @elasticmachine