Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal callback error with multiple report generations / notifications #19285

Closed
liza-mae opened this issue May 21, 2018 · 7 comments · Fixed by elastic/eui#865
Closed

Fatal callback error with multiple report generations / notifications #19285

liza-mae opened this issue May 21, 2018 · 7 comments · Fixed by elastic/eui#865
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.3.0

Comments

@liza-mae
Copy link
Contributor

liza-mae commented May 21, 2018

Kibana version: 6.3.0 BC6
Elasticsearch version: 6.3.0 BC6
Server OS version: OSX
Browser version: Chrome / Firefox
Browser OS version: Latest
Original install method (e.g. download page, yum, from source, etc.): Staging

Describe the bug:
Generating several reports at the same time can cause a fatal error to occur. It is not consistent in reproducing but I do see it happening multiple times. Since I see ToastList in the error message I believe this is to do with the notifications being generated by initiating multiple reports.

Error: Uncaught TypeError: _this.callback is not a function (https://localhost:5605/bundles/vendors.bundle.js:149)
    at window.onerror (commons.bundle.js:3)
fatalError @ commons.bundle.js:3
window.onerror @ commons.bundle.js:3
setTimeout (async)
Timer.resume @ vendors.bundle.js:149
EuiGlobalToastList._this.onMouseLeave @ vendors.bundle.js:149
vendors.bundle.js:149 Uncaught TypeError: _this.callback is not a function
    at Timer.finish (vendors.bundle.js:149)
Timer.finish @ vendors.bundle.js:149
setTimeout (async)
Timer.resume @ vendors.bundle.js:149
EuiGlobalToastList._this.onMouseLeave @ vendors.bundle.js:149
commons.bundle.js:3 Uncaught Error: Uncaught TypeError: _this.callback is not a function (https://localhost:5605/bundles/vendors.bundle.js:149)
    at window.onerror (commons.bundle.js:3)
window.onerror @ commons.bundle.js:3
setTimeout (async)
Timer.resume @ vendors.bundle.js:149
EuiGlobalToastList._this.onMouseLeave @ vendors.bundle.js:149
commons.bundle.js:3 Error: Uncaught TypeError: _this.callback is not a function (https://localhost:5605/bundles/vendors.bundle.js:149)
    at window.onerror (commons.bundle.js:3)
fatalError @ commons.bundle.js:3
window.onerror @ commons.bundle.js:3
setTimeout (async)
Timer.resume @ vendors.bundle.js:149
EuiGlobalToastList._this.onMouseLeave @ vendors.bundle.js:149
vendors.bundle.js:149 Uncaught TypeError: _this.callback is not a function
    at Timer.finish (vendors.bundle.js:149)
Timer.finish @ vendors.bundle.js:149
setTimeout (async)
Timer.resume @ vendors.bundle.js:149
EuiGlobalToastList._this.onMouseLeave @ vendors.bundle.js:149
commons.bundle.js:3 Uncaught Error: Uncaught TypeError: _this.callback is not a function (https://localhost:5605/bundles/vendors.bundle.js:149)
    at window.onerror (commons.bundle.js:3)
window.onerror @ commons.bundle.js:3
setTimeout (async)
Timer.resume @ vendors.bundle.js:149
EuiGlobalToastList._this.onMouseLeave @ vendors.bundle.js:149

Steps to reproduce:

Install Elasticsearch, Kibana
Generate multiple reports, continue navigating in kibana
Sometimes while looking at one report in a tab or just navigating back to the report page a fatal error occurs.

screenshot from 2018-05-20 15-03-32

screenshot from 2018-05-20 15-03-17

@liza-mae liza-mae added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels May 21, 2018
@liza-mae liza-mae changed the title Fatal callback error with multiple report generations or multiple report notifications Fatal callback error with multiple report generations / notifications May 21, 2018
@stacey-gammon stacey-gammon added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label May 22, 2018
@stacey-gammon
Copy link
Contributor

cc @elastic/kibana-design since it seems to be coming from the EUIGlobalToastList code.

@stacey-gammon
Copy link
Contributor

This isn't related to reporting, I was able to trigger by moving my mouse around the toasts that were generated from add panel action.

I think it has to do with the timer.resume starting up a dismissed toast.

fataltoasts

Not sure why reporting toasts do seem to trigger it more quickly though.

@stacey-gammon stacey-gammon removed the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label May 22, 2018
@chandlerprall
Copy link
Contributor

I can replicate in the Toast docs, definitely something internal to EUI.

@chandlerprall
Copy link
Contributor

not solved in kibana yet, re-opening

@chandlerprall
Copy link
Contributor

Is this really a blocker for 6.3? In a psuedo-related conversation with @timroes he said our current backporting policy says we only backport critical security issues to 6.3

@liza-mae
Copy link
Contributor Author

When running multiple report generation tasks in the background, which is probably a common use case, this fatal error can occur multiple times at random times. So it will interrupt any other work that is being done in the browser. Since this is new functionality that did not exist in 6.2.4, in this scenario it will cause the system to act flaky and it should be fixed in 6.3.0. It negatively impacts the user experience and could possibly result in work loss, this is why we decided it should be a blocker.

@liza-mae liza-mae removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed labels May 23, 2018
@nreese
Copy link
Contributor

nreese commented May 24, 2018

closed by #19361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants