Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Notes] - copy changes #193495

Closed
PhilippeOberti opened this issue Sep 19, 2024 · 4 comments
Closed

[Security Solution][Notes] - copy changes #193495

PhilippeOberti opened this issue Sep 19, 2024 · 4 comments
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Milestone

Comments

@PhilippeOberti
Copy link
Contributor

PhilippeOberti commented Sep 19, 2024

Description

Before going GA we need to make sure that we have all the copy changes done.
Here's the copy changes from the Docs team https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit

Acceptance criteria

  • do copy changes
  • Add a link to docs related to pinning/unpinning in timeline (discussion)
@PhilippeOberti PhilippeOberti added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels Sep 19, 2024
@PhilippeOberti PhilippeOberti added this to the 8.16 milestone Sep 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@nastasha-solomon
Copy link
Contributor

Related copy discussions happening here as well.

PhilippeOberti added a commit that referenced this issue Oct 22, 2024
…e the unassociated note advanced setting under the Security Solution section (#197312)

## Summary

This PR tackles 2 small tasks:
- move the unassociated advanced settings introduced in [this
PR](#194947) under the `Security
Solution` category instead of `General`
- make some copy changes on the notes functionality, mainly the
following ([copy changes
document](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))
  - make sure we don't use a capital `N` for the word `note`
  - make sure that we use a capital `T` for the word `timeline`
  - change some of the no message and callout texts
  - prioritize using `attach` instead of `associate`

All changes have been done with @nastasha-solomon.

#193495
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 22, 2024
…e the unassociated note advanced setting under the Security Solution section (elastic#197312)

## Summary

This PR tackles 2 small tasks:
- move the unassociated advanced settings introduced in [this
PR](elastic#194947) under the `Security
Solution` category instead of `General`
- make some copy changes on the notes functionality, mainly the
following ([copy changes
document](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))
  - make sure we don't use a capital `N` for the word `note`
  - make sure that we use a capital `T` for the word `timeline`
  - change some of the no message and callout texts
  - prioritize using `attach` instead of `associate`

All changes have been done with @nastasha-solomon.

elastic#193495
(cherry picked from commit 800e392)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 22, 2024
…e the unassociated note advanced setting under the Security Solution section (elastic#197312)

## Summary

This PR tackles 2 small tasks:
- move the unassociated advanced settings introduced in [this
PR](elastic#194947) under the `Security
Solution` category instead of `General`
- make some copy changes on the notes functionality, mainly the
following ([copy changes
document](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))
  - make sure we don't use a capital `N` for the word `note`
  - make sure that we use a capital `T` for the word `timeline`
  - change some of the no message and callout texts
  - prioritize using `attach` instead of `associate`

All changes have been done with @nastasha-solomon.

elastic#193495
(cherry picked from commit 800e392)
kibanamachine added a commit that referenced this issue Oct 23, 2024
…e + move the unassociated note advanced setting under the Security Solution section (#197312) (#197350)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution][Notes] - copy changes for note and timeline +
move the unassociated note advanced setting under the Security Solution
section (#197312)](#197312)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-10-22T23:20:10Z","message":"[Security
Solution][Notes] - copy changes for note and timeline + move the
unassociated note advanced setting under the Security Solution section
(#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move
the unassociated advanced settings introduced in
[this\r\nPR](#194947) under the
`Security\r\nSolution` category instead of `General`\r\n- make some copy
changes on the notes functionality, mainly the\r\nfollowing ([copy
changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n
- make sure we don't use a capital `N` for the word `note`\r\n - make
sure that we use a capital `T` for the word `timeline`\r\n - change some
of the no message and callout texts\r\n - prioritize using `attach`
instead of `associate`\r\n\r\nAll changes have been done with
@nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] -
copy changes for note and timeline + move the unassociated note advanced
setting under the Security Solution
section","number":197312,"url":"https://github.com/elastic/kibana/pull/197312","mergeCommit":{"message":"[Security
Solution][Notes] - copy changes for note and timeline + move the
unassociated note advanced setting under the Security Solution section
(#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move
the unassociated advanced settings introduced in
[this\r\nPR](#194947) under the
`Security\r\nSolution` category instead of `General`\r\n- make some copy
changes on the notes functionality, mainly the\r\nfollowing ([copy
changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n
- make sure we don't use a capital `N` for the word `note`\r\n - make
sure that we use a capital `T` for the word `timeline`\r\n - change some
of the no message and callout texts\r\n - prioritize using `attach`
instead of `associate`\r\n\r\nAll changes have been done with
@nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197312","number":197312,"mergeCommit":{"message":"[Security
Solution][Notes] - copy changes for note and timeline + move the
unassociated note advanced setting under the Security Solution section
(#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move
the unassociated advanced settings introduced in
[this\r\nPR](#194947) under the
`Security\r\nSolution` category instead of `General`\r\n- make some copy
changes on the notes functionality, mainly the\r\nfollowing ([copy
changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n
- make sure we don't use a capital `N` for the word `note`\r\n - make
sure that we use a capital `T` for the word `timeline`\r\n - change some
of the no message and callout texts\r\n - prioritize using `attach`
instead of `associate`\r\n\r\nAll changes have been done with
@nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
kibanamachine added a commit that referenced this issue Oct 23, 2024
… + move the unassociated note advanced setting under the Security Solution section (#197312) (#197351)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Notes] - copy changes for note and timeline +
move the unassociated note advanced setting under the Security Solution
section (#197312)](#197312)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-10-22T23:20:10Z","message":"[Security
Solution][Notes] - copy changes for note and timeline + move the
unassociated note advanced setting under the Security Solution section
(#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move
the unassociated advanced settings introduced in
[this\r\nPR](#194947) under the
`Security\r\nSolution` category instead of `General`\r\n- make some copy
changes on the notes functionality, mainly the\r\nfollowing ([copy
changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n
- make sure we don't use a capital `N` for the word `note`\r\n - make
sure that we use a capital `T` for the word `timeline`\r\n - change some
of the no message and callout texts\r\n - prioritize using `attach`
instead of `associate`\r\n\r\nAll changes have been done with
@nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] -
copy changes for note and timeline + move the unassociated note advanced
setting under the Security Solution
section","number":197312,"url":"https://github.com/elastic/kibana/pull/197312","mergeCommit":{"message":"[Security
Solution][Notes] - copy changes for note and timeline + move the
unassociated note advanced setting under the Security Solution section
(#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move
the unassociated advanced settings introduced in
[this\r\nPR](#194947) under the
`Security\r\nSolution` category instead of `General`\r\n- make some copy
changes on the notes functionality, mainly the\r\nfollowing ([copy
changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n
- make sure we don't use a capital `N` for the word `note`\r\n - make
sure that we use a capital `T` for the word `timeline`\r\n - change some
of the no message and callout texts\r\n - prioritize using `attach`
instead of `associate`\r\n\r\nAll changes have been done with
@nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197312","number":197312,"mergeCommit":{"message":"[Security
Solution][Notes] - copy changes for note and timeline + move the
unassociated note advanced setting under the Security Solution section
(#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move
the unassociated advanced settings introduced in
[this\r\nPR](#194947) under the
`Security\r\nSolution` category instead of `General`\r\n- make some copy
changes on the notes functionality, mainly the\r\nfollowing ([copy
changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n
- make sure we don't use a capital `N` for the word `note`\r\n - make
sure that we use a capital `T` for the word `timeline`\r\n - change some
of the no message and callout texts\r\n - prioritize using `attach`
instead of `associate`\r\n\r\nAll changes have been done with
@nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Development

No branches or pull requests

3 participants