Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/user_actions - DeleteAttachmentConfirmationModal calls onConfirm #195672

Closed
kibanamachine opened this issue Oct 9, 2024 · 7 comments · Fixed by #200887
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/components/user_actions - DeleteAttachmentConfirmationModal calls onConfirm #195672

kibanamachine opened this issue Oct 9, 2024 · 7 comments · Fixed by #200887
Assignees
@adcoelho
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 9, 2024 •
edited
Loading

A test failed on a tracked branch

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at it (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/user_actions/delete_attachment_confirmation_modal.test.tsx:37:3)
    at _dispatchDescribe (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:91:26)
    at describe (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:55:5)
    at Object.describe (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/user_actions/delete_attachment_confirmation_modal.test.tsx:14:1)
    at Runtime._execModule (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:882:12)
    at jestAdapter (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at runTestInternal (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1728499160505732790/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: kibana-on-merge - 8.x
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 9, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 9, 2024
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Oct 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 9, 2024
@cnasikas cnasikas added the Feature:Cases Cases feature label Oct 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

mistic added a commit that referenced this issue Nov 6, 2024
@mistic
skip flaky suite (#195672)
3a5fa5f
mistic added a commit that referenced this issue Nov 6, 2024
@mistic
skip flaky suite (#195672)
e9010b6
@mistic
Copy link
Member

mistic commented Nov 6, 2024

Skipped.

main: 3a5fa5f
8.x: e9010b6

mgadewoll pushed a commit to mgadewoll/kibana that referenced this issue Nov 7, 2024
@mistic @mgadewoll
skip flaky suite (elastic#195672)
1df00db
@adcoelho adcoelho self-assigned this Nov 20, 2024
@adcoelho adcoelho mentioned this issue Nov 20, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 21, 2024
@adcoelho
[ResponseOps][Cases] Removed custom render from flaky tests (elastic#…
101432a 
…200887)

Closes elastic#189739
Closes elastic#188488
Closes elastic#193482
Closes elastic#192944
Closes elastic#195672

## Summary

Same solution for all of them, I removed `createAppMockRenderer`. In
some cases, I also added missing occurrences of `screen` and updated
`getBy`s to `await screen.findBy*`s.

(cherry picked from commit d3b9a9a)
kibanamachine added a commit that referenced this issue Nov 21, 2024
@kibanamachine @adcoelho
[8.x] [ResponseOps][Cases] Removed custom render from flaky tests (#2…
06f1b16 
…00887) (#201186)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Cases] Removed custom render from flaky tests
(#200887)](#200887)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"antonio.coelho@elastic.co"},"sourceCommit":{"committedDate":"2024-11-21T13:13:28Z","message":"[ResponseOps][Cases]
Removed custom render from flaky tests (#200887)\n\nCloses
#189739\r\nCloses #188488\r\nCloses #193482\r\nCloses #192944\r\nCloses
#195672\r\n\r\n## Summary\r\n\r\nSame solution for all of them, I
removed `createAppMockRenderer`. In\r\nsome cases, I also added missing
occurrences of `screen` and updated\r\n`getBy`s to `await
screen.findBy*`s.","sha":"d3b9a9a050f1c7b2d77710bda55b2e59ec6b668a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["technical
debt","release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor"],"title":"[ResponseOps][Cases]
Removed custom render from flaky
tests","number":200887,"url":"https://github.com/elastic/kibana/pull/200887","mergeCommit":{"message":"[ResponseOps][Cases]
Removed custom render from flaky tests (#200887)\n\nCloses
#189739\r\nCloses #188488\r\nCloses #193482\r\nCloses #192944\r\nCloses
#195672\r\n\r\n## Summary\r\n\r\nSame solution for all of them, I
removed `createAppMockRenderer`. In\r\nsome cases, I also added missing
occurrences of `screen` and updated\r\n`getBy`s to `await
screen.findBy*`s.","sha":"d3b9a9a050f1c7b2d77710bda55b2e59ec6b668a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200887","number":200887,"mergeCommit":{"message":"[ResponseOps][Cases]
Removed custom render from flaky tests (#200887)\n\nCloses
#189739\r\nCloses #188488\r\nCloses #193482\r\nCloses #192944\r\nCloses
#195672\r\n\r\n## Summary\r\n\r\nSame solution for all of them, I
removed `createAppMockRenderer`. In\r\nsome cases, I also added missing
occurrences of `screen` and updated\r\n`getBy`s to `await
screen.findBy*`s.","sha":"d3b9a9a050f1c7b2d77710bda55b2e59ec6b668a"}}]}]
BACKPORT-->

Co-authored-by: Antonio <antonio.coelho@elastic.co>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@adcoelho @paulinashakirova
[ResponseOps][Cases] Removed custom render from flaky tests (elastic#…
745a7b4 
…200887)

Closes elastic#189739
Closes elastic#188488
Closes elastic#193482
Closes elastic#192944
Closes elastic#195672

## Summary

Same solution for all of them, I removed `createAppMockRenderer`. In
some cases, I also added missing occurrences of `screen` and updated
`getBy`s to `await screen.findBy*`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ResponseOps][Cases] Removed custom render from flaky tests adcoelho/kibana
5 participants
@adcoelho @mistic @cnasikas @elasticmachine @kibanamachine