Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset Quality] 🐞 Data stream detail page breadcrumb not working on Project nav #195734

Closed
tonyghiani opened this issue Oct 10, 2024 · 1 comment · Fixed by #196281
Closed

[Dataset Quality] 🐞 Data stream detail page breadcrumb not working on Project nav #195734

tonyghiani opened this issue Oct 10, 2024 · 1 comment · Fixed by #196281
Assignees
@tonyghiani
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@tonyghiani
Copy link
Contributor

📓 Summary

Once the navigation mode is set to project, the breadcrumbs are not updating correctly for the detail page of a data stream.

Screen.Recording.2024-10-10.at.12.00.07.mov

✔ Acceptance criteria

When project navigation mode is enabled, breadcrumbs for the data stream page...

  • should add at the end of the breadcrumbs chain a tag with the data stream name.
  • should link the Data Set Quality breadcrumb to the page with all the listed data sets.

💡 Implementation hints

The issue is probably caused by useBreadcrumbs which does not account for the difference in setting the serverless breadcrumbs.
Updating the implementation similarly to how this useBreadcrumbs works should help to solve the issue.
@tonyghiani tonyghiani added bug Fixes for quality problems that affect the customer experience Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team labels Oct 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@yngrdyn yngrdyn changed the title [Dataset Quality] Data stream detail page breadcrumb not working on Project nav [Dataset Quality] 🐞 Data stream detail page breadcrumb not working on Project nav Oct 11, 2024
@tonyghiani tonyghiani self-assigned this Oct 15, 2024
@tonyghiani tonyghiani mentioned this issue Oct 15, 2024
Merged
tonyghiani added a commit that referenced this issue Oct 16, 2024
@tonyghiani
[Dataset Quality] Fix project view breadcrumbs (#196281)
e470999 
## 📓 Summary

Closes #195734 

These changes fix the project navigation breadcrumbs by making the
result consistent between the different navigation modes.

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 16, 2024
@tonyghiani
[Dataset Quality] Fix project view breadcrumbs (elastic#196281)
5abb430 
## 📓 Summary

Closes elastic#195734

These changes fix the project navigation breadcrumbs by making the
result consistent between the different navigation modes.

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
(cherry picked from commit e470999)
kibanamachine added a commit that referenced this issue Oct 16, 2024
@kibanamachine @tonyghiani
[8.x] [Dataset Quality] Fix project view breadcrumbs (#196281) (#196484)
be392ba 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dataset Quality] Fix project view breadcrumbs
(#196281)](#196281)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2024-10-16T07:05:49Z","message":"[Dataset
Quality] Fix project view breadcrumbs (#196281)\n\n## 📓
Summary\r\n\r\nCloses #195734 \r\n\r\nThese changes fix the project
navigation breadcrumbs by making the\r\nresult consistent between the
different navigation modes.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"e47099924b2d993387bf33ba59210cad22d394f0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"[Dataset
Quality] Fix project view
breadcrumbs","number":196281,"url":"https://github.com/elastic/kibana/pull/196281","mergeCommit":{"message":"[Dataset
Quality] Fix project view breadcrumbs (#196281)\n\n## 📓
Summary\r\n\r\nCloses #195734 \r\n\r\nThese changes fix the project
navigation breadcrumbs by making the\r\nresult consistent between the
different navigation modes.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"e47099924b2d993387bf33ba59210cad22d394f0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196281","number":196281,"mergeCommit":{"message":"[Dataset
Quality] Fix project view breadcrumbs (#196281)\n\n## 📓
Summary\r\n\r\nCloses #195734 \r\n\r\nThese changes fix the project
navigation breadcrumbs by making the\r\nresult consistent between the
different navigation modes.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"e47099924b2d993387bf33ba59210cad22d394f0"}}]}]
BACKPORT-->

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyghiani tonyghiani

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dataset Quality] Fix project view breadcrumbs tonyghiani/kibana
2 participants
@elasticmachine @tonyghiani