Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Do not swallow errors from trying to save completed job data #26386

Closed
tsullivan opened this issue Nov 28, 2018 · 4 comments
Closed
Assignees
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@tsullivan
Copy link
Member

tsullivan commented Nov 28, 2018

Kibana 6.2.x:

  1. Set http.max_content_length in Elasticsearch to something really low, like 1mb
  2. Run a CSV report to generate output greater than 1mb, but less than xpack.reporting.csv.maxSizeBytes
  3. Expected results:
    • See a log message in the Kibana server with the HTTP (should be a 413 status code) error message that came from Elasticsearch. ES does not need to log the error.
    • The job data for the failed report should have a useful error message, not "Max attempts reached (3)"

Actual result: any useful error message seems to be swallowed - never logged properly

Related: A warning should be logged if the xpack.reporting.csv.maxSizeBytes in Kibana is greater than http.max_content_length in ES: #26383

@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 28, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@joelgriffith
Copy link
Contributor

💥 starting on this

@joelgriffith
Copy link
Contributor

Took some time to get to the bottom of it, but here's a preliminary PR: #28629

@joelgriffith
Copy link
Contributor

Downstream PR is merged (as is the backport). Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants