Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client not trusting server certificate are logged using the "error" log level #35004

Closed
kobelb opened this issue Apr 12, 2019 · 9 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kobelb
Copy link
Contributor

kobelb commented Apr 12, 2019

We presently only downgrade selective client errors from the "error" level to the "info" level here. We aren't presently downgrading TLS/SSL errors, so when a client connects to Kibana and doesn't trust the certificate, the following is logged:

[18:22:31.675] [error][client][connection] Error: 4443837888:error:14094416:SSL routines:ssl3_read_bytes:sslv3 alert certificate unknown:../deps/openssl/openssl/ssl/s3_pkt.c:1498:SSL alert number 46

This is just an example of the type of errors that we log, they're numerous and I'm not seeing a way to classify them easily off-hand besides using a regex, or changing the way in which Hapi classifies all tls errors as client connection errors.

@kobelb kobelb changed the title SSL related client errors SSL client errors Apr 12, 2019
@kobelb kobelb changed the title SSL client errors SSL/TLS errors are logged using the "error" log level Apr 12, 2019
@kobelb kobelb added the Team:Operations Team label for Operations Team label Apr 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@seiddegu
Copy link

@kobelb ,

Is there any config directive to set to some level, to surpass this error ?

Regards;

@jbudz jbudz added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@jbudz
Copy link
Member

jbudz commented Mar 19, 2020

Adding platform, mostly to cc.

@peter-wang-wsl
Copy link

can this log non-display by import .p12 file into browser?

@tylersmalley tylersmalley removed the Team:Operations Team label for Operations Team label Sep 21, 2021
@Leaf-Lin
Copy link
Contributor

Can we reduce the severity of this from error to info?

@mshustov mshustov added the bug Fixes for quality problems that affect the customer experience label Nov 19, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort labels Nov 29, 2021
@lukeelmers
Copy link
Member

@kobelb Grooming through old issues, and it looks like we had labeled this issue as impact:high, but I'm not certain if that's accurate. In your opinion, do you feel this is a high-impact bug?

@kobelb
Copy link
Contributor Author

kobelb commented Jul 12, 2022

@kobelb Grooming through old issues, and it looks like we had labeled this issue as impact:high, but I'm not certain if that's accurate. In your opinion, do you feel this is a high-impact bug?

IMO, it's more of a medium impact issue. It's likely a considerable annoyance in a number of situations. For example, if anyone is using Kibana's server logs to monitor the number of errors that are thrown, this will skew these numbers because an incorrect logging level is used. Additionally, I've anecdotally sent developers down the path of thinking that Kibana is doing something wrong, when it's really something that the "client" is doing wrong.

@lukeelmers lukeelmers added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Aug 1, 2022
@exalate-issue-sync exalate-issue-sync bot changed the title SSL/TLS errors are logged using the "error" log level Client not trusting server certificate are logged using the "error" log level Nov 9, 2022
@TinaHeiligers
Copy link
Contributor

they're numerous and I'm not seeing a way to classify them easily off-hand besides using a regex
@kobelb, I'm going through logs of these where I can find them to see the variation between the errors.

Would a regex such as /ssl3_read_bytes:sslv3/ be a good match?

TinaHeiligers added a commit that referenced this issue Nov 19, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fix #35004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

10 participants