Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change status code colors on trace summary #45406

Closed
smith opened this issue Sep 11, 2019 · 5 comments · Fixed by #47114
Closed

Change status code colors on trace summary #45406

smith opened this issue Sep 11, 2019 · 5 comments · Fixed by #47114
Assignees
@cauemarcondes
Labels
good first issue low hanging fruit Team:APM All issues that need APM UI Team support

Comments

@smith
Copy link
Contributor

smith commented Sep 11, 2019

As discussed on #44842, we should replace the use of euiPaletteForStatus on the the trace summary with these colors:

  • 1xx: #69707D (euiColorDarkShade)
  • 2xx: #017D73 (euiColorSecondary)
  • 3xx: #69707D (euiColorDarkShade)
  • 4xx: #F5A700 (euiColorWarning)
  • 5xx: #BD271E (euiColorDanger)

Ensure all of these have proper contrast with the text.
@smith smith added the Team:APM All issues that need APM UI Team support label Sep 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@smith smith mentioned this issue Sep 11, 2019
Merged
7 tasks
@formgeist formgeist mentioned this issue Sep 20, 2019
Closed
@cauemarcondes cauemarcondes self-assigned this Oct 2, 2019
@cauemarcondes
Copy link
Contributor

@sqren these colors have different value based on the theme (light or dark), do you want to keep the light colors even when dark mode is on?

@sorenlouv
Copy link
Member

@cauemarcondes Good point. After inspecting the colors I think the changes are okay though. The green is still green in dark mode (just a different shade).

@formgeist
Copy link
Contributor

I also think we should keep the changes made by the dark theme.

@cauemarcondes
Copy link
Contributor

PR: #47114

@cauemarcondes cauemarcondes mentioned this issue Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cauemarcondes cauemarcondes

Labels
good first issue low hanging fruit Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM]Changing status code colors on trace summary cauemarcondes/kibana
5 participants
@smith @sorenlouv @formgeist @elasticmachine @cauemarcondes