Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] navigation via the minichart is confusing #48614

Closed
katrin-freihofner opened this issue Oct 18, 2019 · 9 comments
Closed

[Logs UI] navigation via the minichart is confusing #48614

katrin-freihofner opened this issue Oct 18, 2019 · 9 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@katrin-freihofner
Copy link
Contributor

This came up when building kibana master locally (using the shared dev cluster).

Browser version:
Chrome Version 77.0.3865.90 (Official Build) (64-bit)

Browser OS version:
Mac

Describe the bug:
When clicking on a specific time in the mini-chart (6am and 9am) as a user, I suppose the stream would show me log lines from this time. But the timestamp of the log lines that show up is a different one. Additionally, the minichart also moves, which I haven't expected.

Expected behavior:
When clicking on a time, log lines with the appropriate timestamp show up. The minichart does not move at all.

logs-nav

@katrin-freihofner katrin-freihofner added bug Fixes for quality problems that affect the customer experience Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary Zacqary self-assigned this Oct 21, 2019
@Zacqary
Copy link
Contributor

Zacqary commented Oct 21, 2019

Two issues here:

  1. When the log minimap is working correctly, we need to change UX so that we don't move it when the user clicks on a new time. Only move it when the user scrolls up and down.
  2. The request to get new logs centered around the timestamp where the user clicks still isn't always working correctly

I'd thought issue 2 was only happening when trying to click on a point where there were no logs, but the gif clearly shows the user clicking on a place where there's a significant enough log density to jump to that section.

Perhaps related, when checking to confirm this behavior on my local machine, I ran into this:
Screen Shot 2019-10-21 at 12 53 52 PM

Note that there are no logs past October 18th, but because I'm looking at the UI on October 21st it's still rendering a completely blank minimap. Not sure if that's the same underlying cause but it's something to note

@Zacqary
Copy link
Contributor

Zacqary commented Oct 21, 2019

So for some reason the getYScale function returns inaccurate results on page load, and only becomes accurate again after you click and drag the log minimap. Trying to find out why. It might be related to the way target is handled; this is supposed to represent the midpoint of the displayed logs on screen, but sometimes it doesn't if logs aren't dense enough to get results at that exact midpoint.

@Zacqary
Copy link
Contributor

Zacqary commented Oct 21, 2019

#48826 fixes issue 2 from my above summary.

@Zacqary
Copy link
Contributor

Zacqary commented Oct 22, 2019

Some further commentary on the UX portion of this issue:

Currently, the log minimap will re-render every time the target (current timestamp) changes, so that the center of the minimap roughly corresponds to the center of the displayed logs. For example:
Screen Shot 2019-10-22 at 12 54 20 PM

The blue line on the minimap is pointing to 06:00:36.839.

This expected behavior is asking us to break from this convention. For instance, if I clicked on 3 AM, we would want to freeze the minimap in place and move the blue line up to around 3 AM.

I like this idea and I agree it would reduce confusion, but I think it begs some additional questions:

  • Does the minimap still move when the user scrolls up and down, or does it also stay frozen?
  • If it stays frozen, what happens when the user scrolls all the way to the top or bottom edge of the minimap? Do we then scroll the minimap, or do we have it jump an entire screen?
  • If we're no longer tying the minimap to the center of the scroll panel, how do we decide what portion of the minimap initially renders?

@hbharding tagging you on this since we need UX input

@katrin-freihofner
Copy link
Contributor Author

  • Does the minimap still move when the user scrolls up and down, or does it also stay frozen?

It stays frozen

  • If it stays frozen, what happens when the user scrolls all the way to the top or bottom edge of the minimap? Do we then scroll the minimap, or do we have it jump an entire screen?

The minimap gets scales to show the extended timeframe.

  • If we're no longer tying the minimap to the center of the scroll panel, how do we decide what portion of the minimap initially renders?

The timeframe that is selected in the datepicker. And in case of live streaming we have to pick a start time (for example now - 2 h).

@Zacqary Zacqary added the enhancement New value added to drive a business result label Oct 24, 2019
@weltenwort
Copy link
Member

I think most of these problems will be dealt with via #49154. The mini-map will show exactly the date range selected in the time picker and clicking will jump to the location. The interval visible in the stream to the right will continue to be shown as a highlighted window, but it won't always be centered anymore.

@Zacqary
Copy link
Contributor

Zacqary commented Oct 25, 2019

@katrin-freihofner Since the bug portion of this ticket is fixed should we move over to #49154 for the UX changes? Or are these still in their own scope do you think?

@katrin-freihofner
Copy link
Contributor Author

@Zacqary yes, I think it works much better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

5 participants