-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Replace current timepicker with EUI SuperDatePicker #49154
Comments
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Love these changes, it seems like it'll make for a much better UX while also reducing technical complexity of the rendering code. Few questions:
Can the user still scroll up to cancel live streaming, or do they have to manually click the Stop button first before unlocking the scroll?
Does this behavior also work for clicking and dragging the log minimap? It seems like it would make sense for the minimap-drag action to change the timeframe now rather than executing a |
I suspect that trying to load the logs entries quickly enough to keep up with a large-scale drag operation on the minimap would be futile. If we limit the maximum drag distance to the boundaries of the minimap the first case should always apply, right? |
I could make an argument for either. @katrin-freihofner, any preference? |
That sounds pretty intuitive to me, except for the 6pm at the end. Where does that come from? |
If a user streams for one hour, it would be 6pm in the example above. |
Ah, I see. We could either keep the end date as |
I agree! That sounds good. |
👍 I've amended the description above |
To summarize a discussion at EAH: @afgomez and I are going to pair on the backend/frontend portions of this issue. We can implement this UI in an unoptimized way using the current GraphQL APIs, so that work can happen in parallel with building a more efficient backend. Right now the backend fetches the 200 next or previous log entries whenever the user scrolls to "load new entries." This is inefficient because we don't have a start and end timerange to look for these 200 logs; we need to exponentially extend the timeframe until 200 of them actually get retrieved. This doesn't give Elasticsearch a lot of room to optimize our queries. Same with jumping to a new timestamp; we just pass a central timestamp, and the algorithm now has to use the same method to collect 200 surrounding log entries to display. This UI will allow us to just pass a start and end timeframe to Elasticsearch, allowing query performance to improve dramatically. When this issue is ready for implementation, we should probably convert it to a meta-issue and create frontend and backend sub-issues. |
Summary
This lays out the steps to replace the current point-in-time picker in the Logs UI with EUI's SuperDatePicker as discussed in #37217.
Task breakdown
Acceptance criteria
<SuperDatePicker>
).(now-1d, now)
.now
or in the future.now
or in the future).(now-1d, now)
and auto-refresh to5s
.The text was updated successfully, but these errors were encountered: