Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Replace Query Bar with EuiSuggest component and fix performance issues #52930

Closed
Zacqary opened this issue Dec 12, 2019 · 3 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature performance Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Dec 12, 2019

Kibana version:
7.6

Browser version:
Firefox 71 and Chrome 79

Browser OS version:
MacOS 10.14.6

Describe the bug:
Typing a character into the Query Bar on the Logs Stream page sometimes takes a second or more to display the character typed. This is due to performance issues with the autocomplete box.

@simianhacker suggested using the Saved Search with Filter component to alleviate this issue

As per discussion below, we should fix performance issues in the kuery parser, and use the EuiSuggest component, to alleviate these issues.

@Zacqary Zacqary added bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Dec 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort
Copy link
Member

Given that using the "Saved Search with Filter" adds a lot more complexity and new features I feel these should be treated separately:

  1. Fix potential performance problems in the kuery parser and replace the filter bar with an EuiSuggest component.
  2. Deliberate introducing the "Saved Search with Filter" component and clarify possible roadblocks (e.g. Kibana index pattern dependencies).

@Zacqary Zacqary changed the title [Logs UI] Replace Query Bar with Saved Search with Filters component to fix performance issues [Logs UI] Replace Query Bar with EuiSuggest component and fix performance issues Dec 17, 2019
@jasonrhodes
Copy link
Member

We should wait on this until we've investigated the SearchBar component from the data plugin to see if it's an easy drop-in replacement that solves most of these issues. See #53123 (comment)

and #53310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature performance Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

6 participants