Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB needs a "tsvb:max_buckets" target setting for auto instead of a default 120 buckets #54012

Closed
Paul-de-Barbeyrac opened this issue Jan 6, 2020 · 5 comments · Fixed by #83628
Closed

TSVB needs a "tsvb:max_buckets" target setting for auto instead of a default 120 buckets #54012

Paul-de-Barbeyrac opened this issue Jan 6, 2020 · 5 comments · Fixed by #83628
Assignees
@alexwizp
Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Paul-de-Barbeyrac
Copy link

Describe the feature:
When interval is set to auto in the Time Series Visual Builder, the TSVB seems to be splitting the selected time range into 120 buckets maximum.

Describe a specific use case for the feature:
This is a serious limitation for the user who wants to see trends over long period of time with a decent granularity. Since he can choose from a few seconds time range to up to years, the alternative to increase the general max_bucket setting and set each time the interval manually based on the time span is not acceptable.

In a nutshell, the wanted feature is a TSVB auto field targetting a tsvb:max_buckets in advanced settings. This setting exists for timelion but not for tsvb.

Thank you
@wylieconlon
Copy link
Contributor

The size here can be increased only if the total number of buckets in the response is under 10,000. Splitting your visualization by Terms or adding many Filter Ratios might push it over the limit. I would propose that instead of using an advanced setting, TSVB should be more dynamic and have a slider that lets users increase the granularity.

@wylieconlon wylieconlon added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@Paul-de-Barbeyrac
Copy link
Author

Thank you @wylieconlon !
The slider would be indeed a great feature, much appreciated.

In our case, we monitor industrial assets streaming data every 10s. As you recommended, I already have filters setup to target a specific equipment on the vizualisation, but due to this demanding sampling time, I am afraid this 10 000 limit is rapidly reached and prevents looking at long term trends with a decent granularity (as an example 1 year trend is displaying data aggregated over roughly 3 days bucket which is unsufficient for our business needs).

This feature would be nice since the repsonse time on the TSVB is amazingly fast and we could definitely afford to wait a bit longer for a better granularity.

Will follow-up on this. Thank you

@wylieconlon
Copy link
Contributor

In general we are looking at ways to support long-running searches in Kibana, such as #48811 and this effort might be related. Showing denser time series data makes sense for lots of our users.

@markov00 markov00 added the enhancement New value added to drive a business result label May 29, 2020
@Paul-de-Barbeyrac
Copy link
Author

Is there any update on this ? Just upgraded to 7.10 and see no improvements related to it. Thank you

@alexwizp alexwizp self-assigned this Nov 16, 2020
@alexwizp alexwizp mentioned this issue Nov 18, 2020
Merged
5 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 20, 2020
@alexwizp
TSVB needs a "tsvb:max_buckets" target setting for auto instead of a …
898a6ae 
…default 120 buckets

Closes: elastic#54012
alexwizp added a commit that referenced this issue Nov 24, 2020
@alexwizp @kibanamachine @wylieconlon
TSVB should use "histogram:maxBars" and "histogram:barTarget" setting…
6ef6c0f 
…s for auto instead of a default 100 buckets (#83628)

* TSVB needs a "tsvb:max_buckets" target setting for auto instead of a default 120 buckets

Closes: #54012

* remove calculate_auto

* max bars -> Level of detail

* rename allowLevelofDetail

* fix PR comment

* Update constants.ts

* Update src/plugins/vis_type_timeseries/public/application/components/index_pattern.js

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* create LEVEL_OF_DETAIL_MIN_BUCKETS constant

* calcAutoIntervalLessThan -> search.aggs.calcAutoIntervalLessThan

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 24, 2020
@alexwizp
TSVB should use "histogram:maxBars" and "histogram:barTarget" setting…
e23bc7f 
…s for auto instead of a default 100 buckets (elastic#83628)

* TSVB needs a "tsvb:max_buckets" target setting for auto instead of a default 120 buckets

Closes: elastic#54012

* remove calculate_auto

* max bars -> Level of detail

* rename allowLevelofDetail

* fix PR comment

* Update constants.ts

* Update src/plugins/vis_type_timeseries/public/application/components/index_pattern.js

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* create LEVEL_OF_DETAIL_MIN_BUCKETS constant

* calcAutoIntervalLessThan -> search.aggs.calcAutoIntervalLessThan

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
# Conflicts:
#	src/plugins/data/server/server.api.md
alexwizp added a commit that referenced this issue Nov 25, 2020
@alexwizp
TSVB should use "histogram:maxBars" and "histogram:barTarget" setting…
8e0b99a 
…s for auto instead of a default 100 buckets (#83628) (#84250)

* TSVB needs a "tsvb:max_buckets" target setting for auto instead of a default 120 buckets

Closes: #54012

* remove calculate_auto

* max bars -> Level of detail

* rename allowLevelofDetail

* fix PR comment

* Update constants.ts

* Update src/plugins/vis_type_timeseries/public/application/components/index_pattern.js

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* create LEVEL_OF_DETAIL_MIN_BUCKETS constant

* calcAutoIntervalLessThan -> search.aggs.calcAutoIntervalLessThan

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
# Conflicts:
#	src/plugins/data/server/server.api.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
5 participants
@wylieconlon @markov00 @elasticmachine @alexwizp @Paul-de-Barbeyrac