[APM] [Service map] Animate adding elements #54796
Assignees
Labels
apm:service-maps
Service Map feature in APM
Team:APM
All issues that need APM UI Team support
v7.7.0
Comments
|
Pinging @elastic/apm-ui (Team:apm) |
smith
added a commit
to smith/kibana
that referenced
this issue
Jan 27, 2020
We had previously deleted the animation because the method we were using for adding nodes to the map would wipe the whole map out before redrawing it and make for very awkward animation. The way it works now is the Cytoscape component calls `add` on the cytoscape instance when new elements are added, so the animation looks ok. Fixes elastic#54796.
smith
added a commit
that referenced
this issue
Jan 27, 2020
We had previously deleted the animation because the method we were using for adding nodes to the map would wipe the whole map out before redrawing it and make for very awkward animation. The way it works now is the Cytoscape component calls `add` on the cytoscape instance when new elements are added, so the animation looks ok. Fixes #54796. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
smith
added a commit
to smith/kibana
that referenced
this issue
Jan 31, 2020
We had previously deleted the animation because the method we were using for adding nodes to the map would wipe the whole map out before redrawing it and make for very awkward animation. The way it works now is the Cytoscape component calls `add` on the cytoscape instance when new elements are added, so the animation looks ok. Fixes elastic#54796. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
smith
added a commit
that referenced
this issue
Jan 31, 2020
We had previously deleted the animation because the method we were using for adding nodes to the map would wipe the whole map out before redrawing it and make for very awkward animation. The way it works now is the Cytoscape component calls `add` on the cytoscape instance when new elements are added, so the animation looks ok. Fixes #54796.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently when new elements are added to the map it replaces the entire elements array which causes the entire map to be re-rendered.
If we turn on animation with the current method, it just makes it so everything disappears and then the entire new map layout is animated.
Make it so adding new elements to the map triggers a layout, rearranging the map but without wiping and re-rendering the whole thing.
A possible solution for this might be to add elements using Cytoscape's
addmethod instead of having the elements be props to the Cytoscape component and re-rendering the React component.The text was updated successfully, but these errors were encountered: