Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto upgrade for date fields #55533

Closed
pgomulka opened this issue Jan 22, 2020 · 5 comments
Closed

Implement auto upgrade for date fields #55533

pgomulka opened this issue Jan 22, 2020 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.8.6

Comments

@pgomulka
Copy link

pgomulka commented Jan 22, 2020

We noticed that there is an increased number of users struggling to migrate their mappings with date fields using old style joda patterns. Since 7.0 they need to upgrade to java.style patterns on these date fields.
This requires an index with a new mapping and a reindex.
Because this is a change in 7.0 I suppose I would need to have a logic like this in 6.8.

Should I implement this in javascript in kibana? Or should I aim to use the new infrastructure with painless #49764 (although I see an 8.0 label..)
The logic would be fairly simple and would perform automatic reindex only when a mapping migration can be 100% determined. Things like YYYY -> yyyy or yyyy -> uuuu and so on.
https://github.com/elastic/elasticsearch/blob/6.8/server/src/main/java/org/elasticsearch/common/joda/JodaDeprecationPatterns.java

Not sure if this should be under the reindex button in migration assistant or a logic invisible to a user?

Let me know what you think

relates issue in ES elastic/elasticsearch#45548

@cjcenizal cjcenizal added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jan 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@pgomulka
Copy link
Author

pgomulka commented Feb 4, 2020

we discussed this during elasticsearch-ui team meeting on 4th Feb
the conclusion is to make sure we will still have an opportunity to release this as a patch to 6.8 version. If this is agreed, then we will proceed with the implementation in kibana (possibly in the area of reindex service)
The alternative is to implement this as script which a user runs on its own and gets a list of commands that helps him create an index with a new mapping, reindex, repoint aliases

Also a points were raised, that reindex at the moment is used for stored objects in kibana, which are not massive (not comparable to some of the indices used by users). Reindex might end up very long and consume resources in kibana.

@cjcenizal cjcenizal added the enhancement New value added to drive a business result label Feb 4, 2020
@alisonelizabeth
Copy link
Contributor

Hi @pgomulka! Can you confirm if this is still relevant for the 7-8 upgrade? I believe when we last talked you mentioned there are too many combinations to cover to provide an "auto-upgrade" experience. Also, that this could only occur with indices created prior to 7.x.

@pgomulka
Copy link
Author

hi @alisonelizabeth , yes I think it is too hard to implement and have a 100% correctness. also the indices created in 6.x are still respected in 7.x so I expect a big group of users won't be affected as their 6.x indices will get removed thanks to data retention.

@alisonelizabeth
Copy link
Contributor

👍 thanks! I'm going to go ahead and close this for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.8.6
Projects
None yet
Development

No branches or pull requests

4 participants