Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty dashboard iframe should not give the access for editing to user #56252

Closed
Tracked by #168126
bhavyarm opened this issue Jan 28, 2020 · 2 comments
Closed
Tracked by #168126

Empty dashboard iframe should not give the access for editing to user #56252

bhavyarm opened this issue Jan 28, 2020 · 2 comments
Assignees
@ThomThomson
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 7.6.0 BC2

Elasticsearch version: 7.6.0 BC2

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If you create an iFrame of an empty dashboard - user can click on edit and get to creating visualizations. But when you share an iframe of a non-empty dashboard - edit button is never accessible to the user.

Steps to reproduce:

  1. Click on create new dashboard
  2. Save it and then click on share ->embed code ->snapshot/saved object ->copy iframe code
  3. save the iframe code in .html
  4. Open the html in a new tab and click edit and then you can create vizs

Expected behavior: Not really sure how this is supposed to look like? Don't give access to share iFrame when dashboard doesn't have anything or block the edit button on shared iFrame

Screenshots (if relevant):
test_iframe
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@Dosant Dosant mentioned this issue Mar 2, 2021
Closed
@kmartastic kmartastic added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Mar 5, 2021
@ThomThomson
Copy link
Contributor

ThomThomson commented Oct 29, 2021 •
edited
Loading

Closing this issue! Because the blank dashboard callout does not contain an edit button, a user looking at a blank dashboard in an iframe will no longer be able to edit it.

Screen Shot 2021-10-29 at 5 46 04 PM

Screen Shot 2021-10-29 at 5 47 52 PM

@ThomThomson ThomThomson self-assigned this Nov 2, 2021
@ThomThomson ThomThomson mentioned this issue Apr 10, 2023
Open
@ThomThomson ThomThomson mentioned this issue Oct 5, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomThomson ThomThomson

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@timroes @bhavyarm @ThomThomson @elasticmachine @kmartastic