Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Support for reading annotations similar to TSVB, from an Elasticsearch query #62277

Closed
timroes opened this issue Apr 2, 2020 · 4 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Apr 2, 2020

Users would like to add annotations to charts (see https://elastic.github.io/elastic-charts/?path=/story/annotations-lines--x-time-domain for an example). Those annotations should be based on documents from (potentially another) index in Elasticsearch.

@timroes timroes added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Apr 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

It would help to define the steps the user would take to add an annotation. If I were a user who was familiar with TSVB, I would expect that the "add layer" button would be the place to add an annotation.

  • Configure a specific XY chart type
  • Add a new layer- the new layer button would need to give you a choice:
    • Add <same chart type>
    • Add line series
    • Add annotations
  • The annotation layer is only allowed to have an X axis and a "text" field

Technical requirements:

  • Visualizations can support different types of layers
  • A datasource that supports individual document queries

@wylieconlon
Copy link
Contributor

wylieconlon commented Jan 6, 2021

After looking into this more and looking at what @AlonaNadler listed as priorities, this is not the highest priority annotation feature. It is a higher priority to be able to insert annotations into an XY chart, than to read from a separate index. This issue is about "read-only annotations", which are queried from Elasticsearch.

There is one main use of this feature today, which is in TSVB sample data visualizations which use the TSVB annotations feature. I don't think this is a blocker for moving to Lens in sample data.

@wylieconlon wylieconlon changed the title [Lens] Support for annotations similar to TSVB [Lens] Support for reading annotations similar to TSVB, from an Elasticsearch query Jan 6, 2021
@timductive timductive added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Feb 14, 2022
@mbondyra mbondyra self-assigned this Sep 12, 2022
@mbondyra
Copy link
Contributor

I think this can be closed in favor of #129299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants