-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Respect number format defined in Kibana Advanced Settings #63458
Comments
Pinging @elastic/apm-ui (Team:apm) |
I think this is similar to #49851 where we can't easily support it because Kibana doesn't have locale settings. Kibana has these settings for number formatting: We can't use the "Number format" option because that also sets the precision (we have different precision depending on the context). I was thinking that perhaps we can use "Formatting locale" since that also contains:
But not sure how that doesn't conflict with the "Number format" option - at least from a UX perspective... I wish that Kibana didn't expose numeral formats directly, but instead exposed specific settings like on Mac OS: Or Airbnb's even simpler approach: There's some work happening in #53972 where we may want to chime in. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing due to inactivity |
Currently, the APM UI does not respect the Kibana formatting settings wrt number separator, as we explicitly override the
format
value when usingnumeral
. This means that users cannot display numbers & percents in the APM UI for their preferred locale. See https://discuss.elastic.co/t/customize-number-separator-in-apm/226573Current UI in Advanced Settings
Suggested solution
Replacing the current UI in Kibana Advanced Settings with dedicated grouping/decimal fields would be a great simplification for the user.
The text was updated successfully, but these errors were encountered: