Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Respect number format defined in Kibana Advanced Settings #63458

Closed
dgieselaar opened this issue Apr 14, 2020 · 4 comments
Closed

[APM] Respect number format defined in Kibana Advanced Settings #63458

dgieselaar opened this issue Apr 14, 2020 · 4 comments
Assignees
Labels
stale Used to mark issues that were closed for being stale Team:APM All issues that need APM UI Team support

Comments

@dgieselaar
Copy link
Member

dgieselaar commented Apr 14, 2020

Currently, the APM UI does not respect the Kibana formatting settings wrt number separator, as we explicitly override the format value when using numeral. This means that users cannot display numbers & percents in the APM UI for their preferred locale. See https://discuss.elastic.co/t/customize-number-separator-in-apm/226573

Current UI in Advanced Settings
image

Suggested solution
Replacing the current UI in Kibana Advanced Settings with dedicated grouping/decimal fields would be a great simplification for the user.

image

@dgieselaar dgieselaar added the Team:APM All issues that need APM UI Team support label Apr 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

sorenlouv commented Apr 27, 2020

I think this is similar to #49851 where we can't easily support it because Kibana doesn't have locale settings.

Kibana has these settings for number formatting:

image

We can't use the "Number format" option because that also sets the precision (we have different precision depending on the context).

I was thinking that perhaps we can use "Formatting locale" since that also contains:

    delimiters: {
        thousands: ' ',
        decimal: ','
    },

But not sure how that doesn't conflict with the "Number format" option - at least from a UX perspective...

I wish that Kibana didn't expose numeral formats directly, but instead exposed specific settings like on Mac OS:

image

Or Airbnb's even simpler approach:

image

There's some work happening in #53972 where we may want to chime in.

@sorenlouv sorenlouv changed the title [APM] Respect Kibana format settings in APM UI [APM] Respect number format defined in Advanced Settings May 15, 2020
@sorenlouv sorenlouv changed the title [APM] Respect number format defined in Advanced Settings [APM] Respect number format defined in Kibana Advanced Settings May 15, 2020
@botelastic
Copy link

botelastic bot commented Nov 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Nov 1, 2021
@sorenlouv
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used to mark issues that were closed for being stale Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

5 participants