[Maps] Problem on Edit Filter

[flaviogoncalves]

Describe the feature:

Elasticsearch version (bin/elasticsearch --version):

7.6.2

JVM version (java -version):

Cloud

OS version (uname -a if on a Unix-like system):

Cloud

Description of the problem including expected versus actual behavior:

In the map, when you click over a city, you can select filters. After selecting a filter, if you try to edit the filter it does not save or apply the new filter.

Steps to reproduce:

1 - Open a map
2 - Have a tooltip associated with any polygon
3- Click in the polygon
4 - Select the filter based on the + symbol of the tooltip

Now try to edit and save the filter created

Please include a minimal but complete recreation of the problem, including
(e.g.) index creation, mappings, settings, query etc. The easier you make for
us to reproduce it, the more likely that somebody will take the time to look at it.

Provide logs (if relevant):

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[thomasneirynck]

thx @flaviogoncalves I can reproduce as described. Will ping back here with updates.

[nreese]

Started to investigate this. It looks like the filters created from maps are not properly setting $state.

Filters created in filter bar UI set $state':(store:appState)
Filters created from Maps app set '$state':appState.

Then in the filter_editor on Submit handler, $state without store just returns early.
https://github.com/elastic/kibana/blob/7.7/src/plugins/data/public/ui/filter_bar/filter_editor/index.tsx#L471

private onSubmit = () => {
    const {
      selectedIndexPattern: indexPattern,
      selectedField: field,
      selectedOperator: operator,
      params,
      useCustomLabel,
      customLabel,
      isCustomEditorOpen,
      queryDsl,
    } = this.state;

    const { $state } = this.props.filter;
    if (!$state || !$state.store) {
      return; // typescript validation
    }