Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[event log] can't find events since action/alert saved object are now hidden #70086

Closed
pmuellr opened this issue Jun 26, 2020 · 1 comment · Fixed by #70395
Closed

[event log] can't find events since action/alert saved object are now hidden #70086

pmuellr opened this issue Jun 26, 2020 · 1 comment · Fixed by #70395
Assignees
@pmuellr
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Jun 26, 2020

Since PR #67109 was merged, the event log hasn't been able to return any events since the alert and action saved objects are now hidden. The savedObjectsClient that's created in the event log needs to be tweaked to look for hidden types for actions and alerts.

There is already a "fix" for this in the branch for PR #68437, but I'm thinking it may be better to extract it out of here and put in a separate PR.

There is also issue #63961, which will again change the way actions/alerts are pre-checked for access before returning the event log - somehow we need to allow actions/alerts to do their own lookup (to find the preconfigured actions), and also to allow them to use their own internal code including RBAC to make a determination if the action/alert is ok.

I think we probably can't wait for issue #63961 to be implemented, so the quick hack of adding hidden type support in #68437 is probably the way to go.
@pmuellr pmuellr added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jun 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris mentioned this issue Jun 26, 2020
Merged
6 tasks
@pmuellr pmuellr self-assigned this Jun 30, 2020
@pmuellr pmuellr mentioned this issue Jul 1, 2020
Merged
1 task
pmuellr added a commit to pmuellr/kibana that referenced this issue Jul 9, 2020
@pmuellr
[eventLog] search for actions/alerts as hidden saved objects
8957be7 
resolves elastic#70086

Configures the saved object client for the event log to access the recently
hidden action and alert saved objects.

We didn't have tests for action/alert event log activity, so added some now.

Also found a buglet that was preventing access to event log data from actions
and alerts in non-default spaces.
pmuellr added a commit that referenced this issue Jul 16, 2020
@pmuellr
[eventLog] search for actions/alerts as hidden saved objects (#70395)
b167d77 
resolves #70086

Configures the saved object client for the event log to access the recently
hidden action and alert saved objects.

We didn't have tests for action/alert event log activity, so added some now.

Also found a buglet that was preventing access to event log data from actions
and alerts in non-default spaces.
pmuellr added a commit to pmuellr/kibana that referenced this issue Jul 16, 2020
@pmuellr
[eventLog] search for actions/alerts as hidden saved objects (elastic…
3552a5a 
…#70395)

resolves elastic#70086

Configures the saved object client for the event log to access the recently
hidden action and alert saved objects.

We didn't have tests for action/alert event log activity, so added some now.

Also found a buglet that was preventing access to event log data from actions
and alerts in non-default spaces.
pmuellr added a commit to pmuellr/kibana that referenced this issue Jul 16, 2020
@pmuellr
[eventLog] search for actions/alerts as hidden saved objects (elastic…
73fac41 
…#70395)

resolves elastic#70086

Configures the saved object client for the event log to access the recently
hidden action and alert saved objects.

We didn't have tests for action/alert event log activity, so added some now.

Also found a buglet that was preventing access to event log data from actions
and alerts in non-default spaces.
pmuellr added a commit that referenced this issue Jul 16, 2020
@pmuellr
[eventLog] search for actions/alerts as hidden saved objects (#70395) (…
af55b56 
…#72050)

resolves #70086

Configures the saved object client for the event log to access the recently
hidden action and alert saved objects.

We didn't have tests for action/alert event log activity, so added some now.

Also found a buglet that was preventing access to event log data from actions
and alerts in non-default spaces.
pmuellr added a commit that referenced this issue Jul 16, 2020
@pmuellr
[eventLog] search for actions/alerts as hidden saved objects (#70395) (…
e800029 
…#72049)

resolves #70086

Configures the saved object client for the event log to access the recently
hidden action and alert saved objects.

We didn't have tests for action/alert event log activity, so added some now.

Also found a buglet that was preventing access to event log data from actions
and alerts in non-default spaces.
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmuellr pmuellr

Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[eventLog] search for actions/alerts as hidden saved objects pmuellr/kibana
3 participants
@pmuellr @kobelb @elasticmachine