Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] kbn/optimizer needs ran from source #71881

Closed
tylersmalley opened this issue Jul 15, 2020 · 1 comment · Fixed by #73591
Closed

[build] kbn/optimizer needs ran from source #71881

tylersmalley opened this issue Jul 15, 2020 · 1 comment · Fixed by #73591
Assignees
Labels
Team:Operations Team label for Operations Team v7.10.0 v8.0.0

Comments

@tylersmalley
Copy link
Contributor

tylersmalley commented Jul 15, 2020

We're currently building the Kibana platform plugins from the builds rootPath. The issue is builds only have production dependencies. In order to prevent shipping dependencies used only in client-side code, we will need to be able to move them to devDependencies to accomplish this.

One thing to consider here, is that doing this does not ensure we have a "clean" node_modules. Providing a notice during the build might be enough here since this is not an issue on CI or release manager.

@tylersmalley tylersmalley added Team:Operations Team label for Operations Team v8.0.0 v7.10.0 labels Jul 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants