-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Drilldowns] Dashboard to dashboard drilldown is not maintaining iframe options #77243
Comments
Pinging @elastic/kibana-app-arch (Team:AppArch) |
I think the problem is that when we create a URL to a new dashboard we don't take into account the dashboard app state parameters that are coming from query. here I think the solution would be:
Since this more of a dashboard code change and + we agreed that dashboard drilldown implementation long-term will be maintained by kibana-app team: @majagrubic, @ThomThomson would you mind if I remove |
It turns out that the embed settings being recreated on URL changes caused a large number of issues with filtering dashboards in an iframe. To fix that issue, I cached the embed settings, fetching them from the URL only once on dashboard app start up. #95997 The funny thing is that fix also accidentally fixes this issue. Because the embed settings are cached, they are not read again from the URL on drilldown to another dashboard, so they are maintained. I can't think of any situations in which this would break - because the iframe embed setting removes the ability to navigate outside of the dashboard app anyway. Now my question is, can anyone think of a situation in which this wouldn't be sufficient? Or can we close this issue? |
@ThomThomson Users can definitely leave dashboards when using the iframe. Here are two examples: Discover saved searches link back to Discover, and URL drilldowns can link anywhere. Dashboard-to-dashboard drilldowns can take you to a separate dashboard with new filters. |
I should have been more clear: the embed setting removes the ability to navigate freely / easily around Kibana from within the iframe. I've tested and it does seem like #95997, indeed solves the Dashboard-to-Dashboard drilldown problem. Filters are carried over correctly, and the embed options are maintained in the new dashboard. Next week I will do more testing, and see where this breaks. |
Closing this issue for now. Navigating around an iframe from dashboard to dashboard correctly maintains the iframe options due to the caching, which is what this issue was originally about. When a user leaves dashboard, the embed settings are removed, but I think this should be considered expected, because the iframe is specifically a way to share a dashboard. |
Dashboard iframes allow the iframe user to hide the time picker, filters, top menu, and query bar as separate parameters. These parameters should all be maintained when the user clicks a drilldown, as reported on discuss.
The text was updated successfully, but these errors were encountered: