Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Unique Count and Percentiles #7955

Closed
figo-sh opened this issue Aug 8, 2016 · 2 comments
Closed

Rename Unique Count and Percentiles #7955

figo-sh opened this issue Aug 8, 2016 · 2 comments

Comments

@figo-sh
Copy link

figo-sh commented Aug 8, 2016

The names "Unique Count" and "Percentiles" are misleading, as they do not reflect the statistical nature of their underlying algorithms. I propose "Approximate Cardinality" (or "Approximate Unique Count") and "Approximate Percentiles".
It's a subtle difference, but can be of extreme importance, and isn't obvious unless you happen to actually read through the Elasticsearch manual.

@Bargs
Copy link
Contributor

Bargs commented Aug 8, 2016

This is the case for the terms agg as well.

@epixa
Copy link
Contributor

epixa commented Nov 7, 2016

The crux of this issue is described in #8701, so I'm going to close this as a duplicate. Renaming them entirely is one possible option, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants