Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Reset internal state in <LogStream /> when any of the relevant props change #83284

Closed
afgomez opened this issue Nov 12, 2020 · 1 comment · Fixed by #83302
Closed

[Logs UI] Reset internal state in <LogStream /> when any of the relevant props change #83284

afgomez opened this issue Nov 12, 2020 · 1 comment · Fixed by #83302
Assignees
@afgomez
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@afgomez
Copy link
Contributor

afgomez commented Nov 12, 2020 •
edited
Loading

The <LogStream /> component doesn't properly update its internal state (the entries is showing) when any of its props change. This means that when a consumer changes the time range or the query passed to the component, the entries showed don't update.
@afgomez afgomez changed the title [Logs [Logs UI] Reset internal state in <LogStream /> when any of the relevant props change Nov 12, 2020
@afgomez afgomez added Epic:Shared Logs Component Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez self-assigned this Nov 12, 2020
@afgomez afgomez mentioned this issue Nov 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afgomez afgomez

Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs UI] Update <LogStream /> internal state when its props change afgomez/kibana
2 participants
@afgomez @elasticmachine