Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] support abortSignal for mvt requests to allowing canceling no longer needed requests #90440

Closed
nreese opened this issue Feb 5, 2021 · 2 comments · Fixed by #92069
Closed
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result v7.13.0 v8.0.0

Comments

@nreese
Copy link
Contributor

nreese commented Feb 5, 2021

Elasticsearch data requested from Maps application passes abortSignal to requests so that request for no longer needed data can be canceled. MVT requests do not support abortSignal and continue to run even when the results are no longer needed because users move the the map to a new location or changed the query context.

Not canceling unneeded requests causes performance problems with elasticsearch.

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result labels Feb 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese changed the title [Maps] support abortSignal for mvt requests to all canceling no longer needed requests [Maps] support abortSignal for mvt requests to allowing canceling no longer needed requests Feb 5, 2021
@thomasneirynck
Copy link
Contributor

thomasneirynck commented Feb 19, 2021

Aborted requests are propagating like this:

     request.events.aborted$.subscribe({
        next: () => {
          logger.warn(`request next aborted ${query.z}/${query.x}/${query.y}`);
        }
      });

verified this works, but need to put run kibana without the reverse proxy: see #37403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants