Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto switch fields when doing absolute time periods #9225

Closed
markwalkom opened this issue Nov 26, 2016 · 4 comments
Closed

Auto switch fields when doing absolute time periods #9225

markwalkom opened this issue Nov 26, 2016 · 4 comments
Labels
Feature:Timepicker Timepicker good first issue low hanging fruit release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@markwalkom
Copy link
Contributor

When picking an absolute time period it involves manually typing timestamps, ie;
screen shot 2016-11-26 at 14 02 10 pm

It'd be awesome if a user could click in (eg in the example above) the hour field, type 21 and then we jumped into the minute field and highlighted that to prompt the user to either accept or replace the values. Then repeat for seconds and milliseconds. Of if you started in the year field, do the same.

Currently if you went to enter 21:00:00.000 and just typed the values, you'd get something like 210000000:00:00.000 (if you started at 01:00:00.000) as we don't validate the individual fields.

Essentially we shouldn't rely on the user to only put in the N relevant values each field actually requires, and we should shift to the next field when those N values have been entered.

@dhruvdutt
Copy link

@lukasolson Is this covered in #10433

@lukasolson
Copy link
Member

@dhruvdutt Not really, this has more to do with how you manually input dates, not what date is selected when you click on it in the picker.

@dhruvdutt
Copy link

Alright. I'll take a look at it 👀 and see what I can contribute. ✋

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure :Discovery labels Sep 16, 2018
@timroes
Copy link
Contributor

timroes commented Mar 1, 2019

The way the new datepicker is built, this doesn't make much sense anymore, since every side of the range (from/to) can be absolute or relative and are in two separate popups. So these two input fields are not closely related to each other anymore.

@timroes timroes closed this as completed Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Timepicker Timepicker good first issue low hanging fruit release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants