[meta] iFrame embedding inconsitencies

[Dosant]

This is an umbrella issue to discuss and work through various and very similar iFrame embedding clientside bugs like:

• Clicking refresh on iFrame after few user actions gives access to whole of Kibana #89362
• If you navigate to create maps from iFrame - top nav becomes invisible and you get locked in maps app #89208
• If you click edit on shared iframe and then click cancel - top nav bar, time filter and query bar disappears from the frame #87948
• Embedded iframe dashboard filtering does not work #91590
• [Maps] should disable filters if user shares maps in an iFrame without shared filter #89380
• [Drilldowns] Dashboard to dashboard drilldown is not maintaining iframe options #77243
• Empty dashboard iframe should not give the access for editing to user #56252
• Kibana shouldn't display warnings which give access to advanced settings in iFrames  #110055
• Don't show search sessions access in iFrames #119168
• iFrames displays intractable breadcrumbs to dashboards when given access to top menu  #119208

A lot of the bugs are:

1. Land in a dashboard inside an iframe
2. find a way to navigate away from a dashboard (e.g. drilldown or edit visualization),
3. the initial embedding options are lost.

It would make sense to tackle these issues in batch and since not only dashboard app supports embedding and there is a way to navigate from a dashboard to other apps while you in embed mode the effort should probably be split between @elastic/kibana-presentation and @elastic/kibana-app-services where are some of services/utilities/documentation on embedding would become a part of share plugin.

Some common themes that we will need to work through:

1. When you land into a dashboard with specific view topbar options, make sure those options are persistent when navigating between apps: If you navigate to create maps from iFrame - top nav becomes invisible and you get locked in maps app #89208 [Drilldowns] Dashboard to dashboard drilldown is not maintaining iframe options #77243
2. How to handle navigation to apps that don't explicitly support embedding (e.g. Maps If you navigate to create maps from iFrame - top nav becomes invisible and you get locked in maps app #89208, visualize/edit Empty dashboard iframe should not give the access for editing to user #56252).
   2.1. One option could be to block all navigation outside of the dashboard when embedded
3. Multiple issues around filters / uiActions when embed 😮 could be related to URL based state management Embedded iframe dashboard filtering does not work #91590
4. Problems with short URL and embedding Short url: Embed flag is not respected #72830, Embed Snapshot with Short URL, ?embed=true not working to remove header and nav drawer #50107 (should a solution be as part of URL services?

[Dosant]

This issue is created as part of @elastic/kibana-app-services fix-it-week mostly to group embedding related bugs together.
It doesn't look like these are high-impact issues that require immediate attention, but it would be nice to have this meta for future discussions and for linking more consideration in case something else comes up until we prioritize these embedding issues.

[voidel]

I disagree with the sentiment that these are not high-impact issues. Slightly confused how these have slipped under the radar on release as these have rendered embedded dashboards wholly unusable.

[ThomThomson]

@voidel, some of these issues are indeed marked high-impact, and have been fixed for 7.12.1 (#94471, #94467, #94465). With these fixed, exported dashboards should be usable again.

The remainder of the issues linked here are relatively low priority, fortunately, they are on our radar to be fixed.

Which issues are affecting your use case the most?

[voidel]

Hey @ThomThomson, #94465 and #94467 are the real killers at the moment as they have manifested themselves in our testing environment, rendering our application broken there and leaving us unable to deploy into production until they are fixed. Glad to hear they are fixed and an update is coming, however.

Perhaps we were too eager with updating!

[AndePa01]

Hello, I hope it is okay to bring up an issue that is affecting us that I just created that is also embedded iFrame related.

#100300

Thank you!

[massifazio]

I have opened this one which seems to be related: https://github.com/elastic/sdh-kibana/issues/1615

[ppisljar]

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.