Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply the filter trigger action if filter bar is not present #97455

Closed
stratoula opened this issue Apr 19, 2021 · 5 comments
Closed

Do not apply the filter trigger action if filter bar is not present #97455

stratoula opened this issue Apr 19, 2021 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Actions impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@stratoula
Copy link
Contributor

stratoula commented Apr 19, 2021

Describe the feature:
Right now we have visualizations that do not support the filter bar. (showFilterBar is set to false). TSVB is a great example of it. There is an enhancement that we want to add to TSVB (#83892) to enable the filter by clicking on the timeseries visualization.

This filtering should work only when a TSVB visualization is embedded on a dashboard (and the showFilterBar is set to true) but now when a user is creating/editing it.

As it is right now, I can't differentiate it and the filtering works even if the filter bar is not present. We would like to enhance the trigger action to be only considered compatible when the filter bar exists on the page. The same should happen for the timepicker.

@stratoula stratoula added Feature:Filters enhancement New value added to drive a business result Team:AppServices labels Apr 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant
Copy link
Contributor

Dosant commented Apr 22, 2021

I think there is a similar problem on a dashboard: Dashboard could be displayed without a filter bar, but filters could be applied via actions from embeddable.

@ppisljar
Copy link
Member

filter bar is just showing the state of filter manager. its possible to have your own implementation of filter bar so it being shown or not should not be a deciding factor.

we could disable filtering completely on the filter manager if that's desired.

we could also disable the action that applies the filter in the apps that we don't want to allow adding filters thru actions

@Dosant
Copy link
Contributor

Dosant commented May 11, 2021

I think this should somehow be solved with a new condition check inside apply filter action:

return context.filters !== undefined;

Apps should continue using triggers as is, but this global action should not be compatible in this particular case.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 8, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Actions impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

5 participants