Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet + Integrations UI] Integrations UI Cleanup #104641

Merged
merged 9 commits into from
Jul 7, 2021

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Jul 7, 2021

Summary

Addresses a number of minor issues that were surfaced during our design review of the top-level Integrations UI work.

Closes #104549

Kibana Home Page Fleet Messaging Adjustments

Screen Shot 2021-07-07 at 8 52 53 AM

Kibana "Add Data" Fleet Messaging Adjustments

Screen Shot 2021-07-07 at 8 50 23 AM

Screen Shot 2021-07-07 at 8 56 09 AM

Renamed Kibana Feature to "Fleet and Integrations"

Screen Shot 2021-07-07 at 8 40 48 AM

Expand Dashboard Assets Panel by Default, Pluralize Asset Type Titles

Screen Shot 2021-07-07 at 8 41 41 AM

Update Global Search type field from "package" to "integrations"

Screen Shot 2021-07-07 at 8 42 14 AM

Screen Shot 2021-07-07 at 8 42 25 AM

Update "Add Agent" Flyout on Package Policy listing page + Expand Enrollment Token by Default

Screen Shot 2021-07-07 at 9 00 40 AM

@kpollich kpollich added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 7, 2021
@kpollich kpollich self-assigned this Jul 7, 2021
@kpollich kpollich requested a review from a team as a code owner July 7, 2021 13:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 716.1KB 716.3KB +239.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 448.0KB 448.0KB +34.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 7907b6a into elastic:master Jul 7, 2021
@kpollich kpollich deleted the 104549-integration-ui-cleanup branch July 7, 2021 17:57
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
* Remove Beta wording from Fleet messaging in ingestion tutorials

* Rename fleet feature registration to include integrations

* Pluralize + sentence case assets and expand dashboards by default

* Update global search from packages -> integrations

* Expand auth settings by default in package policy add agent flyout

* Update wording for various fleet modules

* Fix i18n

* Fix unit test

* Fix failing tests
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.14 Commit could not be cherrypicked due to conflicts
7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 104641

kpollich added a commit to kpollich/kibana that referenced this pull request Jul 7, 2021
* Remove Beta wording from Fleet messaging in ingestion tutorials

* Rename fleet feature registration to include integrations

* Pluralize + sentence case assets and expand dashboards by default

* Update global search from packages -> integrations

* Expand auth settings by default in package policy add agent flyout

* Update wording for various fleet modules

* Fix i18n

* Fix unit test

* Fix failing tests
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
kpollich added a commit to kpollich/kibana that referenced this pull request Jul 7, 2021
* Remove Beta wording from Fleet messaging in ingestion tutorials

* Rename fleet feature registration to include integrations

* Pluralize + sentence case assets and expand dashboards by default

* Update global search from packages -> integrations

* Expand auth settings by default in package policy add agent flyout

* Update wording for various fleet modules

* Fix i18n

* Fix unit test

* Fix failing tests
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
kibanamachine added a commit that referenced this pull request Jul 7, 2021
* Remove Beta wording from Fleet messaging in ingestion tutorials

* Rename fleet feature registration to include integrations

* Pluralize + sentence case assets and expand dashboards by default

* Update global search from packages -> integrations

* Expand auth settings by default in package policy add agent flyout

* Update wording for various fleet modules

* Fix i18n

* Fix unit test

* Fix failing tests

Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
kpollich added a commit that referenced this pull request Jul 7, 2021
* Remove Beta wording from Fleet messaging in ingestion tutorials

* Rename fleet feature registration to include integrations

* Pluralize + sentence case assets and expand dashboards by default

* Update global search from packages -> integrations

* Expand auth settings by default in package policy add agent flyout

* Update wording for various fleet modules

* Fix i18n

* Fix unit test

* Fix failing tests
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 8, 2021
…-of-max-results

* 'master' of github.com:elastic/kibana: (36 commits)
  Lower Kibana app bundle limits (elastic#104688)
  [Security Solutions] Fixes bug with the filter query compatibility for transforms (elastic#104559)
  [RAC] Add mapping update logic to RuleDataClient (elastic#102586)
  Fix import workpad (elastic#104722)
  [canvas] Fix Storybook service decorator (elastic#104750)
  [Detection Rules] Add 7.14 rules (elastic#104772)
  [Enterprise Search] Fix beta notification in sidebar (elastic#104763)
  Fix engine routes that are meta engine or non-meta-engine specific (elastic#104757)
  [Fleet] Fix policy revision number getting bumped for no reason (elastic#104696)
  persistable state migrations (elastic#103680)
  [Fleet] Fix add agent in the package policy table (elastic#104749)
  [DOCS] Creates separate doc for security in production (elastic#103973)
  [SO Migration] fix reindex race on multi-instance mode (elastic#104516)
  [Security Solution] Update text in Endpoint Admin pages (elastic#104649)
  [package testing] Decrease timeout to 2 hours (elastic#104668)
  Fix background styling of waterfall chart sidebar tooltip. (elastic#103997)
  [Fleet + Integrations UI] Integrations UI Cleanup (elastic#104641)
  [Fleet] Link to download page of current stack version on Agent install instructions (elastic#104494)
  [Workplace Search] Fix Media Type field preview is unformatted bug (elastic#104684)
  [ML] add marker body (elastic#104672)
  ...

# Conflicts:
#	x-pack/plugins/fleet/public/search_provider.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Integration UI design review cleanup
4 participants