[App Search] Fix engine routes that are meta engine or non-meta-engine specific #104757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to include conditionals in their routing - this matches their nav link behavior - we should have checks in routes as well just in case
cee-chen
added
bug
byronhulcher
approved these changes
Jul 7, 2021
💔 Backport failed
To backport manually run: |
cee-chen
pushed a commit
to cee-chen/kibana
that referenced
this pull request
Jul 8, 2021
…lastic#104757) - to include conditionals in their routing - this matches their nav link behavior - we should have checks in routes as well just in case # Conflicts: # x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.test.tsx
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 8, 2021
…-of-max-results * 'master' of github.com:elastic/kibana: (36 commits) Lower Kibana app bundle limits (elastic#104688) [Security Solutions] Fixes bug with the filter query compatibility for transforms (elastic#104559) [RAC] Add mapping update logic to RuleDataClient (elastic#102586) Fix import workpad (elastic#104722) [canvas] Fix Storybook service decorator (elastic#104750) [Detection Rules] Add 7.14 rules (elastic#104772) [Enterprise Search] Fix beta notification in sidebar (elastic#104763) Fix engine routes that are meta engine or non-meta-engine specific (elastic#104757) [Fleet] Fix policy revision number getting bumped for no reason (elastic#104696) persistable state migrations (elastic#103680) [Fleet] Fix add agent in the package policy table (elastic#104749) [DOCS] Creates separate doc for security in production (elastic#103973) [SO Migration] fix reindex race on multi-instance mode (elastic#104516) [Security Solution] Update text in Endpoint Admin pages (elastic#104649) [package testing] Decrease timeout to 2 hours (elastic#104668) Fix background styling of waterfall chart sidebar tooltip. (elastic#103997) [Fleet + Integrations UI] Integrations UI Cleanup (elastic#104641) [Fleet] Link to download page of current stack version on Agent install instructions (elastic#104494) [Workplace Search] Fix Media Type field preview is unformatted bug (elastic#104684) [ML] add marker body (elastic#104672) ... # Conflicts: # x-pack/plugins/fleet/public/search_provider.test.ts
cee-chen
pushed a commit
that referenced
this pull request
Jul 8, 2021
…fic (#104757) (#104794) * Fix engine routes that are meta engine or non-meta-engine specific (#104757) - to include conditionals in their routing - this matches their nav link behavior - we should have checks in routes as well just in case # Conflicts: # x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.test.tsx * Fix bad merge conflict
cee-chen
pushed a commit
that referenced
this pull request
Jul 8, 2021
…ific (#104757) (#104795) * Fix engine routes that are meta engine or non-meta-engine specific (#104757) - to include conditionals in their routing - this matches their nav link behavior - we should have checks in routes as well just in case # Conflicts: # x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.test.tsx * Fix bad merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update meta/non-meta engine routes to include their respective
isMetaEngineconditional. This matches their nav link behavior, and is basically an extra safety check for inquisitive users or wonky link issues.I noticed this in #104693 (which we're no longer fully using) and pulled it out to its own separate PR
Before
After
Checklist