From 82dcd266aab64e2987bb33eaacdb2cdfb74f6b20 Mon Sep 17 00:00:00 2001 From: dej611 Date: Mon, 12 Jul 2021 16:55:32 +0200 Subject: [PATCH 1/2] :fire: Remove value labels flag for vertical displacement --- x-pack/plugins/lens/public/xy_visualization/expression.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/lens/public/xy_visualization/expression.tsx b/x-pack/plugins/lens/public/xy_visualization/expression.tsx index 3fe98282a18b0..aed3cce9287d6 100644 --- a/x-pack/plugins/lens/public/xy_visualization/expression.tsx +++ b/x-pack/plugins/lens/public/xy_visualization/expression.tsx @@ -908,7 +908,7 @@ export function XYChart({ valueFormatter: (d: unknown) => yAxis?.formatter?.convert(d) || '', showValueLabel: shouldShowValueLabels && valueLabels !== 'hide', isAlternatingValueLabel: false, - isValueContainedInElement: true, + isValueContainedInElement: false, hideClippedValue: true, }, }; From af8de3b046890d51b80dc2b1757877ba212cd9a0 Mon Sep 17 00:00:00 2001 From: dej611 Date: Tue, 13 Jul 2021 12:15:28 +0200 Subject: [PATCH 2/2] :camera: Update snapshot tests --- .../__snapshots__/expression.test.tsx.snap | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/x-pack/plugins/lens/public/xy_visualization/__snapshots__/expression.test.tsx.snap b/x-pack/plugins/lens/public/xy_visualization/__snapshots__/expression.test.tsx.snap index 1f647680408d7..504410356a28d 100644 --- a/x-pack/plugins/lens/public/xy_visualization/__snapshots__/expression.test.tsx.snap +++ b/x-pack/plugins/lens/public/xy_visualization/__snapshots__/expression.test.tsx.snap @@ -337,7 +337,7 @@ exports[`xy_expression XYChart component it renders bar 1`] = ` Object { "hideClippedValue": true, "isAlternatingValueLabel": false, - "isValueContainedInElement": true, + "isValueContainedInElement": false, "showValueLabel": false, "valueFormatter": [Function], } @@ -401,7 +401,7 @@ exports[`xy_expression XYChart component it renders bar 1`] = ` Object { "hideClippedValue": true, "isAlternatingValueLabel": false, - "isValueContainedInElement": true, + "isValueContainedInElement": false, "showValueLabel": false, "valueFormatter": [Function], } @@ -560,7 +560,7 @@ exports[`xy_expression XYChart component it renders horizontal bar 1`] = ` Object { "hideClippedValue": true, "isAlternatingValueLabel": false, - "isValueContainedInElement": true, + "isValueContainedInElement": false, "showValueLabel": false, "valueFormatter": [Function], } @@ -624,7 +624,7 @@ exports[`xy_expression XYChart component it renders horizontal bar 1`] = ` Object { "hideClippedValue": true, "isAlternatingValueLabel": false, - "isValueContainedInElement": true, + "isValueContainedInElement": false, "showValueLabel": false, "valueFormatter": [Function], } @@ -1221,7 +1221,7 @@ exports[`xy_expression XYChart component it renders stacked bar 1`] = ` Object { "hideClippedValue": true, "isAlternatingValueLabel": false, - "isValueContainedInElement": true, + "isValueContainedInElement": false, "showValueLabel": false, "valueFormatter": [Function], } @@ -1289,7 +1289,7 @@ exports[`xy_expression XYChart component it renders stacked bar 1`] = ` Object { "hideClippedValue": true, "isAlternatingValueLabel": false, - "isValueContainedInElement": true, + "isValueContainedInElement": false, "showValueLabel": false, "valueFormatter": [Function], } @@ -1452,7 +1452,7 @@ exports[`xy_expression XYChart component it renders stacked horizontal bar 1`] = Object { "hideClippedValue": true, "isAlternatingValueLabel": false, - "isValueContainedInElement": true, + "isValueContainedInElement": false, "showValueLabel": false, "valueFormatter": [Function], } @@ -1520,7 +1520,7 @@ exports[`xy_expression XYChart component it renders stacked horizontal bar 1`] = Object { "hideClippedValue": true, "isAlternatingValueLabel": false, - "isValueContainedInElement": true, + "isValueContainedInElement": false, "showValueLabel": false, "valueFormatter": [Function], }